Good suggestion. I will split it and resend them.
Regards,
Weidong
Mark McLoughlin wrote:
> Hi Weidong,
>
> In general, this looks like a good cleanup.
>
> With deassign_device() fixed to only require assigned_dev_id, I would
> be happy to ACK this whole patch.
>
> However, it would be much, m
Hi Weidong,
In general, this looks like a good cleanup.
With deassign_device() fixed to only require assigned_dev_id, I would be
happy to ACK this whole patch.
However, it would be much, much easier to review the patch if you had
split it into multiple patches e.g.
1) Make init_assigned_devic
when hot remove a device with iommu, should deassign it from guest,
and free it from qemu.
assign_dev_update_irqs may not be invoked when hot add a device,
so need to assign irq after assign device in init_assigned_device.
Signed-off-by: Weidong Han
---
qemu/hw/device-assignment.c | 187 ++
