Re: [PATCH 4/5] KVM: SVM: Allow EFER.LMSLE to be set with nested svm

2010-05-06 Thread Roedel, Joerg
On Wed, May 05, 2010 at 04:57:00PM -0400, Przywara, Andre wrote: If I understood this correctly, there is a bug somewhere, maybe even in KVM's nested SVM implementation. Xen is fine with this bit-set provoking a #GP. I haven't had time yet to further investigate this, though. Ok, I looked

[PATCH 4/5] KVM: SVM: Allow EFER.LMSLE to be set with nested svm

2010-05-05 Thread Joerg Roedel
This patch enables setting of efer bit 13 which is allowed in all SVM capable processors. This is necessary for the SLES11 version of Xen 4.0 to boot with nested svm. Signed-off-by: Joerg Roedel joerg.roe...@amd.com --- arch/x86/include/asm/msr-index.h |2 ++ arch/x86/kvm/svm.c

Re: [PATCH 4/5] KVM: SVM: Allow EFER.LMSLE to be set with nested svm

2010-05-05 Thread Avi Kivity
On 05/05/2010 05:04 PM, Joerg Roedel wrote: This patch enables setting of efer bit 13 which is allowed in all SVM capable processors. This is necessary for the SLES11 version of Xen 4.0 to boot with nested svm. Interesting, why does it require it? Obviously it isn't needed since it

Re: [PATCH 4/5] KVM: SVM: Allow EFER.LMSLE to be set with nested svm

2010-05-05 Thread Joerg Roedel
On Wed, May 05, 2010 at 05:46:59PM +0300, Avi Kivity wrote: On 05/05/2010 05:04 PM, Joerg Roedel wrote: This patch enables setting of efer bit 13 which is allowed in all SVM capable processors. This is necessary for the SLES11 version of Xen 4.0 to boot with nested svm. Interesting, why

Re: [PATCH 4/5] KVM: SVM: Allow EFER.LMSLE to be set with nested svm

2010-05-05 Thread Avi Kivity
On 05/05/2010 06:04 PM, Joerg Roedel wrote: Because there is no cpuid bit for this feature. That is sad. You can roughly check for it using the svm cpuid bit. Doesn't it kill cross-vendor migration? -- error compiling committee.c: too many arguments to function -- To unsubscribe from

Re: [PATCH 4/5] KVM: SVM: Allow EFER.LMSLE to be set with nested svm

2010-05-05 Thread Roedel, Joerg
On Wed, May 05, 2010 at 11:06:59AM -0400, Avi Kivity wrote: On 05/05/2010 06:04 PM, Joerg Roedel wrote: You can roughly check for it using the svm cpuid bit. Doesn't it kill cross-vendor migration? Enabling Nested SVM kills it anyway, so this is not an issue. AFAIK the feature is not

Re: [PATCH 4/5] KVM: SVM: Allow EFER.LMSLE to be set with nested svm

2010-05-05 Thread Andre Przywara
Avi Kivity wrote: On 05/05/2010 05:04 PM, Joerg Roedel wrote: This patch enables setting of efer bit 13 which is allowed in all SVM capable processors. This is necessary for the SLES11 version of Xen 4.0 to boot with nested svm. Interesting, why does it require it? It does not. Best is