Re: [PATCH 4/9] KVM: define kvm_bad_pfn statically

2012-08-03 Thread Xiao Guangrong
Marcelo, Paul, Thanks for your review! On 08/03/2012 08:01 AM, Paul Mackerras wrote: On Thu, Aug 02, 2012 at 10:15:27AM -0300, Marcelo Tosatti wrote: Remind me what is the guarantee that -Exxx does not clash with a valid pfn number? A pfn number is an address PAGE_SHIFT, so it will have

Re: [PATCH 4/9] KVM: define kvm_bad_pfn statically

2012-08-02 Thread Marcelo Tosatti
On Sun, Jul 29, 2012 at 04:14:25PM +0800, Xiao Guangrong wrote: Then, remove get_bad_pfn Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- include/linux/kvm_host.h |1 + virt/kvm/kvm_main.c |7 +-- 2 files changed, 2 insertions(+), 6 deletions(-) diff

Re: [PATCH 4/9] KVM: define kvm_bad_pfn statically

2012-08-02 Thread Paul Mackerras
On Thu, Aug 02, 2012 at 10:15:27AM -0300, Marcelo Tosatti wrote: Remind me what is the guarantee that -Exxx does not clash with a valid pfn number? A pfn number is an address PAGE_SHIFT, so it will have the top 12 (at least) bits clear, whereas -Exxx will have the top bit set. Paul. -- To

[PATCH 4/9] KVM: define kvm_bad_pfn statically

2012-07-29 Thread Xiao Guangrong
Then, remove get_bad_pfn Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- include/linux/kvm_host.h |1 + virt/kvm/kvm_main.c |7 +-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index