Re: [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs

2015-03-09 Thread Peter Maydell
On 9 March 2015 at 21:56, Christoffer Dall christoffer.d...@linaro.org wrote: this function, however, is not used only when migration, but should generally cover the case where you want to synchronize QEMU's state into KVM's state, right? So while it may not be harmful in currently supported

Re: [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs

2015-03-09 Thread Christoffer Dall
On Tue, Mar 03, 2015 at 11:28:21AM +, Alex Bennée wrote: Christoffer Dall christoffer.d...@linaro.org writes: Hi Alex, Seems like you accidentally sent out two copies of this patch, hopefully I'm reviewing the right one... Oops, perils of not wiping your output directory. I

Re: [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs

2015-03-09 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: On 9 March 2015 at 21:56, Christoffer Dall christoffer.d...@linaro.org wrote: this function, however, is not used only when migration, but should generally cover the case where you want to synchronize QEMU's state into KVM's state, right? So

Re: [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs

2015-03-09 Thread Christoffer Dall
On Mon, Mar 09, 2015 at 10:31:19PM +0900, Peter Maydell wrote: On 9 March 2015 at 21:56, Christoffer Dall christoffer.d...@linaro.org wrote: this function, however, is not used only when migration, but should generally cover the case where you want to synchronize QEMU's state into KVM's

Re: [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs

2015-03-03 Thread Alex Bennée
Christoffer Dall christoffer.d...@linaro.org writes: Hi Alex, Seems like you accidentally sent out two copies of this patch, hopefully I'm reviewing the right one... Oops, perils of not wiping your output directory. I think it was just a title tweak! On Wed, Feb 25, 2015 at 04:02:38PM

Re: [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs

2015-03-02 Thread Christoffer Dall
Hi Alex, Seems like you accidentally sent out two copies of this patch, hopefully I'm reviewing the right one... On Wed, Feb 25, 2015 at 04:02:38PM +, Alex Bennée wrote: From: Christoffer Dall christoffer.d...@linaro.org The current code was negatively indexing the cpu state array and

[PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs

2015-02-25 Thread Alex Bennée
From: Christoffer Dall christoffer.d...@linaro.org The current code was negatively indexing the cpu state array and not synchronizing banked spsr register state with the current mode's spsr state, causing occasional failures with migration. Some munging is done to take care of the aarch64