Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-25 Thread Yang, Sheng
On Tuesday 23 September 2008 22:54:53 Amit Shah wrote: > +static uint32_t assigned_dev_pci_read_config(PCIDevice *d, uint32_t > address, +int len) > +{ > + uint32_t val = 0; > + int fd, r; > + > + if ((address >= 0x10 && address <= 0x24)

Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-24 Thread Yang, Sheng
On Thursday 25 September 2008 12:54:46 Yang, Sheng wrote: > On Tuesday 23 September 2008 22:54:53 Amit Shah wrote: > > From: Or Sagi <[EMAIL PROTECTED]> > > From: Nir Peleg <[EMAIL PROTECTED]> > > From: Amit Shah <[EMAIL PROTECTED]> > > From: Ben-Ami Yassour <[EMAIL PROTECTED]> > > From: Weidong Ha

Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-24 Thread Yang, Sheng
On Tuesday 23 September 2008 22:54:53 Amit Shah wrote: > From: Or Sagi <[EMAIL PROTECTED]> > From: Nir Peleg <[EMAIL PROTECTED]> > From: Amit Shah <[EMAIL PROTECTED]> > From: Ben-Ami Yassour <[EMAIL PROTECTED]> > From: Weidong Han <[EMAIL PROTECTED]> > From: Glauber de Oliveira Costa <[EMAIL PROTEC

Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-24 Thread Amit Shah
* On Wednesday 24 Sep 2008 20:37:24 Anthony Liguori wrote: > Amit Shah wrote: > > * On Tuesday 23 Sep 2008 22:00:32 Anthony Liguori wrote: > >> Amit Shah wrote: > >>> diff --git a/qemu/Makefile.target b/qemu/Makefile.target > >>> index 72f3db8..40eb273 100644 > >>> --- a/qemu/Makefile.target > >>>

Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-24 Thread Anthony Liguori
Amit Shah wrote: * On Tuesday 23 Sep 2008 22:00:32 Anthony Liguori wrote: Amit Shah wrote: diff --git a/qemu/Makefile.target b/qemu/Makefile.target index 72f3db8..40eb273 100644 --- a/qemu/Makefile.target +++ b/qemu/Makefile.target @@ -616,6 +616,7 @@ OBJS+= ide.o pckbd.o ps2.o vga

Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-23 Thread Amit Shah
* On Tuesday 23 Sep 2008 22:00:32 Anthony Liguori wrote: > Amit Shah wrote: > > diff --git a/qemu/Makefile.target b/qemu/Makefile.target > > index 72f3db8..40eb273 100644 > > --- a/qemu/Makefile.target > > +++ b/qemu/Makefile.target > > @@ -616,6 +616,7 @@ OBJS+= ide.o pckbd.o ps2.o vga.o $(SOUND_

Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-23 Thread Anthony Liguori
Muli Ben-Yehuda wrote: On Tue, Sep 23, 2008 at 02:18:51PM -0500, Anthony Liguori wrote: Make sure you issue iopl() before any of the VCPU threads are spawned. Otherwise, you may be running into issues when something other than VCPU-0 is doing PIO/MMIO and you haven't iopl()'d for that threa

Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-23 Thread Muli Ben-Yehuda
On Tue, Sep 23, 2008 at 02:18:51PM -0500, Anthony Liguori wrote: > Make sure you issue iopl() before any of the VCPU threads are > spawned. Otherwise, you may be running into issues when something > other than VCPU-0 is doing PIO/MMIO and you haven't iopl()'d for > that thread. Yeah, we thought

Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-23 Thread Anthony Liguori
Muli Ben-Yehuda wrote: On Tue, Sep 23, 2008 at 11:30:32AM -0500, Anthony Liguori wrote: + + (addr - r_access->e_physbase); + + if (r_access->debug & DEVICE_ASSIGNMENT_DEBUG_PIO) { + fprintf(stderr, "%s: r_pio=%08x e_physbase=%08x" + " r_

Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-23 Thread Muli Ben-Yehuda
On Tue, Sep 23, 2008 at 11:30:32AM -0500, Anthony Liguori wrote: > >> ++ (addr - r_access->e_physbase); >> + >> +if (r_access->debug & DEVICE_ASSIGNMENT_DEBUG_PIO) { >> +fprintf(stderr, "%s: r_pio=%08x e_physbase=%08x" >> +" r_virtbase=%08lx value=%08

Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-23 Thread Anthony Liguori
Amit Shah wrote: From: Or Sagi <[EMAIL PROTECTED]> From: Nir Peleg <[EMAIL PROTECTED]> From: Amit Shah <[EMAIL PROTECTED]> From: Ben-Ami Yassour <[EMAIL PROTECTED]> From: Weidong Han <[EMAIL PROTECTED]> From: Glauber de Oliveira Costa <[EMAIL PROTECTED]> With this patch, we can assign a device o

[PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-23 Thread Amit Shah
From: Or Sagi <[EMAIL PROTECTED]> From: Nir Peleg <[EMAIL PROTECTED]> From: Amit Shah <[EMAIL PROTECTED]> From: Ben-Ami Yassour <[EMAIL PROTECTED]> From: Weidong Han <[EMAIL PROTECTED]> From: Glauber de Oliveira Costa <[EMAIL PROTECTED]> With this patch, we can assign a device on the host machine