Re: [PATCH 6/9] KVM: VMX: simplify invpcid handling in vmx_cpuid_update()

2015-09-08 Thread Xiao Guangrong
On 09/07/2015 07:28 PM, Paolo Bonzini wrote: On 21/08/2015 06:50, Xiao Guangrong wrote: + if (vmx_invpcid_supported() && (!best || Please start the "(" subexpression on a new line. Okay, will fix. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a

Re: [PATCH 6/9] KVM: VMX: simplify invpcid handling in vmx_cpuid_update()

2015-09-07 Thread Paolo Bonzini
On 21/08/2015 06:50, Xiao Guangrong wrote: > + if (vmx_invpcid_supported() && (!best || Please start the "(" subexpression on a new line. Paolo > + !(best->ebx & bit(X86_FEATURE_INVPCID)) || > + !guest_cpuid_has_pcid(vcpu))) { -- To unsubscribe from this list: send the

[PATCH 6/9] KVM: VMX: simplify invpcid handling in vmx_cpuid_update()

2015-08-20 Thread Xiao Guangrong
If vmx_invpcid_supported() is true, second execution control filed must be supported and SECONDARY_EXEC_ENABLE_INVPCID must have already been set in current vmcs by vmx_secondary_exec_control() If vmx_invpcid_supported() is false, no need to clear SECONDARY_EXEC_ENABLE_INVPCID Signed-off-by: