Re: [PATCH kvmtool] kvm__emulate_io: Don't call br_read_unlock() twice on IO error

2015-08-07 Thread Will Deacon
On Thu, Aug 06, 2015 at 07:39:44PM +0100, Josh Triplett wrote: The IO error path in kvm__emulate_io would call br_read_unlock(), then goto error, which would call br_read_unlock() again. Refactor the control flow to have only one exit path and one call to br_read_unlock(). Thanks, Josh. I

[PATCH kvmtool] kvm__emulate_io: Don't call br_read_unlock() twice on IO error

2015-08-06 Thread Josh Triplett
The IO error path in kvm__emulate_io would call br_read_unlock(), then goto error, which would call br_read_unlock() again. Refactor the control flow to have only one exit path and one call to br_read_unlock(). Signed-off-by: Josh Triplett j...@joshtriplett.org --- ioport.c | 11 --- 1