Re: [PATCH repost] kvm: drop parameter validation

2012-08-14 Thread Michael S. Tsirkin
On Tue, Aug 14, 2012 at 07:06:08AM +0300, Gleb Natapov wrote: > On Mon, Aug 13, 2012 at 05:59:32PM -0300, Marcelo Tosatti wrote: > > On Mon, Aug 13, 2012 at 05:30:53PM +0300, Gleb Natapov wrote: > > > On Mon, Aug 13, 2012 at 01:43:58PM +0300, Michael S. Tsirkin wrote: > > > > We validate irq pin nu

Re: [PATCH repost] kvm: drop parameter validation

2012-08-13 Thread Gleb Natapov
On Mon, Aug 13, 2012 at 05:59:32PM -0300, Marcelo Tosatti wrote: > On Mon, Aug 13, 2012 at 05:30:53PM +0300, Gleb Natapov wrote: > > On Mon, Aug 13, 2012 at 01:43:58PM +0300, Michael S. Tsirkin wrote: > > > We validate irq pin number when routing is setup, so > > > code handling illegal irq # in pi

Re: [PATCH repost] kvm: drop parameter validation

2012-08-13 Thread Marcelo Tosatti
On Mon, Aug 13, 2012 at 05:30:53PM +0300, Gleb Natapov wrote: > On Mon, Aug 13, 2012 at 01:43:58PM +0300, Michael S. Tsirkin wrote: > > We validate irq pin number when routing is setup, so > > code handling illegal irq # in pic and ioapic on each injection > > is never called. > > Drop it. > > > I

Re: [PATCH repost] kvm: drop parameter validation

2012-08-13 Thread Gleb Natapov
On Mon, Aug 13, 2012 at 01:43:58PM +0300, Michael S. Tsirkin wrote: > We validate irq pin number when routing is setup, so > code handling illegal irq # in pic and ioapic on each injection > is never called. > Drop it. > I would leave BUG_ON there for a while. > Signed-off-by: Michael S. Tsirkin

[PATCH repost] kvm: drop parameter validation

2012-08-13 Thread Michael S. Tsirkin
We validate irq pin number when routing is setup, so code handling illegal irq # in pic and ioapic on each injection is never called. Drop it. Signed-off-by: Michael S. Tsirkin --- Reposting, applies without changes to kvm/next. arch/x86/kvm/i8259.c | 16 +++- virt/kvm/ioapic.c