Re: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

2012-07-24 Thread Alexander Graf
On 07/24/2012 03:26 PM, Bhushan Bharat-R65777 wrote: +struct kvmppc_debug_reg { +#ifdef CONFIG_BOOKE + u32 dbcr0; + u32 dbcr1; + u32 dbcr2; +#ifdef CONFIG_KVM_E500MC + u32 dbcr4; +#endif + u64 iac[KVMPPC_MAX_IAC]; + u64 dac[KVMPPC_MAX_DAC]; +#endif +}; Is ther

RE: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

2012-07-24 Thread Bhushan Bharat-R65777
> > +struct kvmppc_debug_reg { > > +#ifdef CONFIG_BOOKE > > + u32 dbcr0; > > + u32 dbcr1; > > + u32 dbcr2; > > +#ifdef CONFIG_KVM_E500MC > > + u32 dbcr4; > > +#endif > > + u64 iac[KVMPPC_MAX_IAC]; > > + u64 dac[KVMPPC_MAX_D

Re: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

2012-07-24 Thread Alexander Graf
Subject: Re: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers On 07/23/2012 06:19 AM, Bharat Bhushan wrote: IAC/DAC are defined as 32 bit while they are 64 bit wide. So ONE_REG interface is added to set/get them. Signed-off-by: Bharat Bhushan --- v2: - Using copy_to

RE: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

2012-07-23 Thread Bhushan Bharat-R65777
rnel.org; ag...@suse.de; kvm@vger.kernel.org; > >> Bhushan Bharat- > >> R65777 > >> Subject: Re: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC > >> debug registers > >> > >> On 07/23/2012 06:19 AM, Bharat Bhushan wrote: > >>>

Re: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

2012-07-23 Thread Alexander Graf
ONE_REG interface for IAC/DAC debug registers On 07/23/2012 06:19 AM, Bharat Bhushan wrote: IAC/DAC are defined as 32 bit while they are 64 bit wide. So ONE_REG interface is added to set/get them. Signed-off-by: Bharat Bhushan --- v2: - Using copy_to/from_user() apis. arch/powerpc/include/asm

Re: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

2012-07-23 Thread Scott Wood
>> Bharat- >> R65777 >> Subject: Re: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug >> registers >> >> This will exceed the array size if userspace asks to access IAC3/4 on an >> e500- >> family chip. > > No , is not the arra

RE: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

2012-07-23 Thread Bhushan Bharat-R65777
> -Original Message- > From: Wood Scott-B07421 > Sent: Monday, July 23, 2012 9:12 PM > To: Bhushan Bharat-R65777 > Cc: kvm-...@vger.kernel.org; ag...@suse.de; kvm@vger.kernel.org; Bhushan > Bharat- > R65777 > Subject: Re: [PATCH v2] booke: Added ONE_REG int

Re: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

2012-07-23 Thread Scott Wood
On 07/23/2012 06:19 AM, Bharat Bhushan wrote: > IAC/DAC are defined as 32 bit while they are 64 bit wide. So ONE_REG > interface is added to set/get them. > > Signed-off-by: Bharat Bhushan > --- > v2: > - Using copy_to/from_user() apis. > > arch/powerpc/include/asm/kvm.h | 12 ++ >

[PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

2012-07-23 Thread Bharat Bhushan
IAC/DAC are defined as 32 bit while they are 64 bit wide. So ONE_REG interface is added to set/get them. Signed-off-by: Bharat Bhushan --- v2: - Using copy_to/from_user() apis. arch/powerpc/include/asm/kvm.h | 12 ++ arch/powerpc/include/asm/kvm_host.h | 28 ++- arch/p