Re: [PATCH v2 02/10] KVM: introduce KVM_PFN_ERR_FAULT

2012-08-06 Thread Avi Kivity
On 08/03/2012 10:37 AM, Xiao Guangrong wrote: After that, the exported and un-inline function, get_fault_pfn, can be removed +#define KVM_PFN_ERR_FAULT(-EFAULT) + IMO this symbol isn't needed, just use -EFAULT (and -EHWPOISON etc.) directly. Just document it in hva_to_pfn(), since

Re: [PATCH v2 02/10] KVM: introduce KVM_PFN_ERR_FAULT

2012-08-06 Thread Avi Kivity
On 08/06/2012 04:01 PM, Avi Kivity wrote: On 08/03/2012 10:37 AM, Xiao Guangrong wrote: After that, the exported and un-inline function, get_fault_pfn, can be removed +#define KVM_PFN_ERR_FAULT (-EFAULT) + IMO this symbol isn't needed, just use -EFAULT (and -EHWPOISON etc.)

[PATCH v2 02/10] KVM: introduce KVM_PFN_ERR_FAULT

2012-08-03 Thread Xiao Guangrong
After that, the exported and un-inline function, get_fault_pfn, can be removed Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- arch/x86/kvm/mmu.c |2 +- include/linux/kvm_host.h |3 ++- virt/kvm/kvm_main.c | 12 +++- 3 files changed, 6