Re: [PATCH v2 07/18] KVM/MIPS32: MMU/TLB operations for the Guest.

2013-02-16 Thread Sanjay Lal
On Feb 15, 2013, at 1:41 PM, Gleb Natapov wrote: On Fri, Feb 15, 2013 at 01:19:29PM -0500, Sanjay Lal wrote: On Feb 6, 2013, at 7:08 AM, Gleb Natapov wrote: +static void kvm_mips_map_page(struct kvm *kvm, gfn_t gfn) +{ + pfn_t pfn; + + if (kvm-arch.guest_pmap[gfn] !=

Re: [PATCH v2 07/18] KVM/MIPS32: MMU/TLB operations for the Guest.

2013-02-16 Thread Gleb Natapov
On Sat, Feb 16, 2013 at 10:57:22AM -0500, Sanjay Lal wrote: On Feb 15, 2013, at 1:41 PM, Gleb Natapov wrote: On Fri, Feb 15, 2013 at 01:19:29PM -0500, Sanjay Lal wrote: On Feb 6, 2013, at 7:08 AM, Gleb Natapov wrote: +static void kvm_mips_map_page(struct kvm *kvm, gfn_t gfn)

Re: [PATCH v2 07/18] KVM/MIPS32: MMU/TLB operations for the Guest.

2013-02-15 Thread Sanjay Lal
On Feb 6, 2013, at 7:08 AM, Gleb Natapov wrote: +static void kvm_mips_map_page(struct kvm *kvm, gfn_t gfn) +{ +pfn_t pfn; + +if (kvm-arch.guest_pmap[gfn] != KVM_INVALID_PAGE) +return; + +pfn =kvm_mips_gfn_to_pfn(kvm, gfn); This call should be in srcu read

Re: [PATCH v2 07/18] KVM/MIPS32: MMU/TLB operations for the Guest.

2013-02-15 Thread Gleb Natapov
On Fri, Feb 15, 2013 at 01:19:29PM -0500, Sanjay Lal wrote: On Feb 6, 2013, at 7:08 AM, Gleb Natapov wrote: +static void kvm_mips_map_page(struct kvm *kvm, gfn_t gfn) +{ + pfn_t pfn; + + if (kvm-arch.guest_pmap[gfn] != KVM_INVALID_PAGE) + return; + + pfn

Re: [PATCH v2 07/18] KVM/MIPS32: MMU/TLB operations for the Guest.

2013-02-06 Thread Gleb Natapov
On Wed, Nov 21, 2012 at 06:34:05PM -0800, Sanjay Lal wrote: - Note that this file is statically linked with the rest of the host kernel (KSEG0). This is because kernel modules are loaded into mapped space on MIPS and we want to make sure that we don't get any host kernel TLB faults while

[PATCH v2 07/18] KVM/MIPS32: MMU/TLB operations for the Guest.

2012-11-22 Thread Sanjay Lal
- Note that this file is statically linked with the rest of the host kernel (KSEG0). This is because kernel modules are loaded into mapped space on MIPS and we want to make sure that we don't get any host kernel TLB faults while manipulating TLBs. - Virtual Guest TLBs are implemented as 64 entry