Re: [PATCH v2 11/18] KVM/MIPS32: Routines to handle specific traps/exceptions while executing the guest.

2013-02-18 Thread Sanjay Lal
On Feb 18, 2013, at 1:44 AM, Gleb Natapov wrote: > On Fri, Feb 15, 2013 at 11:10:46AM -0500, Sanjay Lal wrote: >> >> On Feb 6, 2013, at 8:20 AM, Gleb Natapov wrote: >> >>> On Wed, Nov 21, 2012 at 06:34:09PM -0800, Sanjay Lal wrote: +static gpa_t kvm_trap_emul_gva_to_gpa_cb(gva_t gva)

Re: [PATCH v2 11/18] KVM/MIPS32: Routines to handle specific traps/exceptions while executing the guest.

2013-02-18 Thread Gleb Natapov
On Fri, Feb 15, 2013 at 11:10:46AM -0500, Sanjay Lal wrote: > > On Feb 6, 2013, at 8:20 AM, Gleb Natapov wrote: > > > On Wed, Nov 21, 2012 at 06:34:09PM -0800, Sanjay Lal wrote: > >> +static gpa_t kvm_trap_emul_gva_to_gpa_cb(gva_t gva) > >> +{ > >> + gpa_t gpa; > >> + uint32_t kseg = KSEGX(gva)

Re: [PATCH v2 11/18] KVM/MIPS32: Routines to handle specific traps/exceptions while executing the guest.

2013-02-15 Thread Sanjay Lal
On Feb 6, 2013, at 8:20 AM, Gleb Natapov wrote: > On Wed, Nov 21, 2012 at 06:34:09PM -0800, Sanjay Lal wrote: >> +static gpa_t kvm_trap_emul_gva_to_gpa_cb(gva_t gva) >> +{ >> +gpa_t gpa; >> +uint32_t kseg = KSEGX(gva); >> + >> +if ((kseg == CKSEG0) || (kseg == CKSEG1)) > You seems to

Re: [PATCH v2 11/18] KVM/MIPS32: Routines to handle specific traps/exceptions while executing the guest.

2013-02-06 Thread Gleb Natapov
On Wed, Nov 21, 2012 at 06:34:09PM -0800, Sanjay Lal wrote: > +static gpa_t kvm_trap_emul_gva_to_gpa_cb(gva_t gva) > +{ > + gpa_t gpa; > + uint32_t kseg = KSEGX(gva); > + > + if ((kseg == CKSEG0) || (kseg == CKSEG1)) You seems to be using KVM_GUEST_KSEGX variants on gva in all other pla

[PATCH v2 11/18] KVM/MIPS32: Routines to handle specific traps/exceptions while executing the guest.

2012-11-22 Thread Sanjay Lal
Signed-off-by: Sanjay Lal --- arch/mips/kvm/kvm_cb.c| 14 ++ arch/mips/kvm/kvm_trap_emul.c | 482 ++ 2 files changed, 496 insertions(+) create mode 100644 arch/mips/kvm/kvm_cb.c create mode 100644 arch/mips/kvm/kvm_trap_emul.c diff --git a/arch