Re: [PATCH v2 3/5] KVM: Flush TLB in mmu notifier without holding mmu_lock

2012-07-02 Thread Avi Kivity
On 07/02/2012 05:09 PM, Takuya Yoshikawa wrote: > On Mon, 02 Jul 2012 15:41:30 +0300 > Avi Kivity wrote: > >> kvm_mmu_slot_remove_write_access: same. It's hard to continue the loop >> after a lockbreak though. We can switch it to be rmap based instead. > > Switching to rmap based protection wa

Re: [PATCH v2 3/5] KVM: Flush TLB in mmu notifier without holding mmu_lock

2012-07-02 Thread Takuya Yoshikawa
On Mon, 02 Jul 2012 15:41:30 +0300 Avi Kivity wrote: > kvm_mmu_slot_remove_write_access: same. It's hard to continue the loop > after a lockbreak though. We can switch it to be rmap based instead. Switching to rmap based protection was on my queue before, but I wanted to do that after your wor

Re: [PATCH v2 3/5] KVM: Flush TLB in mmu notifier without holding mmu_lock

2012-07-02 Thread Avi Kivity
On 07/02/2012 03:05 PM, Avi Kivity wrote: > We need something for lockbreaking too: > >def mmu_lockbreak(): >if not (contended or need_resched): >return False >remember flush counter >cond_resched_lock >return flush counter changed > > The caller wo

Re: [PATCH v2 3/5] KVM: Flush TLB in mmu notifier without holding mmu_lock

2012-07-02 Thread Avi Kivity
Revisiting after hiatus. On 05/21/2012 11:58 PM, Marcelo Tosatti wrote: > On Thu, May 17, 2012 at 01:24:42PM +0300, Avi Kivity wrote: >> Signed-off-by: Avi Kivity >> --- >> virt/kvm/kvm_main.c | 16 >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/virt/kv

Re: [PATCH v2 3/5] KVM: Flush TLB in mmu notifier without holding mmu_lock

2012-05-21 Thread Marcelo Tosatti
On Mon, May 21, 2012 at 05:58:50PM -0300, Marcelo Tosatti wrote: > On Thu, May 17, 2012 at 01:24:42PM +0300, Avi Kivity wrote: > > Signed-off-by: Avi Kivity > > --- > > virt/kvm/kvm_main.c | 16 > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/virt/kvm/

Re: [PATCH v2 3/5] KVM: Flush TLB in mmu notifier without holding mmu_lock

2012-05-21 Thread Marcelo Tosatti
On Thu, May 17, 2012 at 01:24:42PM +0300, Avi Kivity wrote: > Signed-off-by: Avi Kivity > --- > virt/kvm/kvm_main.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 585ab45..9f6d15d 100644 > --- a/virt/k

[PATCH v2 3/5] KVM: Flush TLB in mmu notifier without holding mmu_lock

2012-05-17 Thread Avi Kivity
Signed-off-by: Avi Kivity --- virt/kvm/kvm_main.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 585ab45..9f6d15d 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -302,11 +302,11 @@ static void kv