Re: [PATCH v2 4/4] KVM: ioapic: reinject pending interrupts on KVM_SET_IRQCHIP

2014-03-24 Thread Radim Krčmář
2014-03-21 10:28+0100, Paolo Bonzini: After the previous patches, an interrupt whose bit is set in the IRR register will never be in the LAPIC's IRR and has never been injected on the migration source. So inject it on the destination. This fixes migration of Windows guests without HPET

Re: [PATCH v2 4/4] KVM: ioapic: reinject pending interrupts on KVM_SET_IRQCHIP

2014-03-24 Thread Paolo Bonzini
Il 24/03/2014 18:58, Radim Krčmář ha scritto: + rtc_irq_eoi_tracking_reset(ioapic); + for_each_set_bit(idx, irr, IOAPIC_NUM_PINS) + ioapic_set_irq(ioapic, idx, 1, true); + + kvm_rtc_eoi_tracking_restore_all(ioapic); (We shouldn't have RTC interrupt with pending EOI in irr, so

Re: [PATCH v2 4/4] KVM: ioapic: reinject pending interrupts on KVM_SET_IRQCHIP

2014-03-24 Thread Radim Krčmář
2014-03-24 19:14+0100, Paolo Bonzini: Il 24/03/2014 18:58, Radim Krčmář ha scritto: I'd prefer 'ioapic-irr = 0' here ...) The point is that ioapic-irr = 0 is overriding the previous memcpy, because state-irr is used as argument to kvm_ioapic_inject_all instead. So I think iopic-irr = 0

[PATCH v2 4/4] KVM: ioapic: reinject pending interrupts on KVM_SET_IRQCHIP

2014-03-21 Thread Paolo Bonzini
After the previous patches, an interrupt whose bit is set in the IRR register will never be in the LAPIC's IRR and has never been injected on the migration source. So inject it on the destination. This fixes migration of Windows guests without HPET (they use the RTC to trigger the scheduler

Re: [PATCH v2 4/4] KVM: ioapic: reinject pending interrupts on KVM_SET_IRQCHIP

2014-03-21 Thread Alex Williamson
On Fri, 2014-03-21 at 10:28 +0100, Paolo Bonzini wrote: After the previous patches, an interrupt whose bit is set in the IRR register will never be in the LAPIC's IRR and has never been injected on the migration source. So inject it on the destination. This fixes migration of Windows guests