Re: [PATCH v3 23/32] nvdimm: build ACPI NFIT table

2015-10-12 Thread Xiao Guangrong
On 10/13/2015 01:42 PM, Michael S. Tsirkin wrote: On Tue, Oct 13, 2015 at 01:13:18PM +0800, Xiao Guangrong wrote: #endif This header is too small to be worth it. nvdimm_get_built_list seems to be the only interface - just stick it in the header you have under include. Other functions

Re: [PATCH v3 23/32] nvdimm: build ACPI NFIT table

2015-10-12 Thread Michael S. Tsirkin
On Tue, Oct 13, 2015 at 01:17:20PM +0800, Xiao Guangrong wrote: > >Would it worth including / copying the ACPICA header files directly? > > > >https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/acpi/actbl1.h > >https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.gi

Re: [PATCH v3 23/32] nvdimm: build ACPI NFIT table

2015-10-12 Thread Michael S. Tsirkin
On Tue, Oct 13, 2015 at 01:13:18PM +0800, Xiao Guangrong wrote: > > > >> #endif > > > >This header is too small to be worth it. > >nvdimm_get_built_list seems to be the only interface - > >just stick it in the header you have under include. > > > > Other functions are introudced and included into

Re: [PATCH v3 23/32] nvdimm: build ACPI NFIT table

2015-10-12 Thread Xiao Guangrong
On 10/13/2015 12:40 AM, Dan Williams wrote: On Sat, Oct 10, 2015 at 8:52 PM, Xiao Guangrong wrote: NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) Currently, we only support PMEM mode. Each device has 3 structures: - SPA structure, defines the PMEM region info - M

Re: [PATCH v3 23/32] nvdimm: build ACPI NFIT table

2015-10-12 Thread Xiao Guangrong
On 10/12/2015 07:27 PM, Michael S. Tsirkin wrote: On Sun, Oct 11, 2015 at 11:52:55AM +0800, Xiao Guangrong wrote: NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) Currently, we only support PMEM mode. Each device has 3 structures: - SPA structure, defines the PMEM re

Re: [PATCH v3 23/32] nvdimm: build ACPI NFIT table

2015-10-12 Thread Dan Williams
On Sat, Oct 10, 2015 at 8:52 PM, Xiao Guangrong wrote: > NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) > > Currently, we only support PMEM mode. Each device has 3 structures: > - SPA structure, defines the PMEM region info > > - MEM DEV structure, it has the @handle wh

Re: [PATCH v3 23/32] nvdimm: build ACPI NFIT table

2015-10-12 Thread Michael S. Tsirkin
On Sun, Oct 11, 2015 at 11:52:55AM +0800, Xiao Guangrong wrote: > NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) > > Currently, we only support PMEM mode. Each device has 3 structures: > - SPA structure, defines the PMEM region info > > - MEM DEV structure, it has the

[PATCH v3 23/32] nvdimm: build ACPI NFIT table

2015-10-10 Thread Xiao Guangrong
NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) Currently, we only support PMEM mode. Each device has 3 structures: - SPA structure, defines the PMEM region info - MEM DEV structure, it has the @handle which is used to associate specified ACPI NVDIMM device we will i