Re: [PATCH v3 3/3] KVM: MMU: retry #PF for softmmu

2010-12-01 Thread Marcelo Tosatti
On Tue, Nov 30, 2010 at 05:37:36PM +0800, Xiao Guangrong wrote: Retry #PF for softmmu only when the current vcpu has the same root shadow page as the time when #PF occurs. it means they have same paging environment Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com ---

Re: [PATCH v3 3/3] KVM: MMU: retry #PF for softmmu

2010-12-01 Thread Xiao Guangrong
On 12/02/2010 09:19 AM, Marcelo Tosatti wrote: On Tue, Nov 30, 2010 at 05:37:36PM +0800, Xiao Guangrong wrote: Can't you just compare cr3 value? Its harmless to instantiate an spte for an unused translation. It may retry #PF in different mmu context, but i think it's acceptable. Will

[PATCH v3 3/3] KVM: MMU: retry #PF for softmmu

2010-11-30 Thread Xiao Guangrong
Retry #PF for softmmu only when the current vcpu has the same root shadow page as the time when #PF occurs. it means they have same paging environment Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com --- arch/x86/include/asm/kvm_host.h |5 + arch/x86/kvm/mmu.c |