Re: [PATCH v3 4/4] KVM: x86: Add VCPU substate for event states

2009-11-04 Thread Avi Kivity
On 11/02/2009 06:20 PM, Jan Kiszka wrote: This new substate exports all yet user-invisible states related to exceptions, interrupts, and NMIs. Together with appropriate user space changes, this fixes sporadic problems of vmsave/restore, live migration and system reset. +

Re: [PATCH v3 4/4] KVM: x86: Add VCPU substate for event states

2009-11-04 Thread Avi Kivity
On 11/04/2009 01:34 PM, Jan Kiszka wrote: we're missing has_error_code here. Isn't it statically defined by the arch? exception_has_error_code() regenerates it (just like user land does). In real mode exceptions lose their error code, so we have to look at cr0, and now we depend

Re: [PATCH v3 4/4] KVM: x86: Add VCPU substate for event states

2009-11-04 Thread Jan Kiszka
Avi Kivity wrote: On 11/04/2009 01:34 PM, Jan Kiszka wrote: we're missing has_error_code here. Isn't it statically defined by the arch? exception_has_error_code() regenerates it (just like user land does). In real mode exceptions lose their error code, so we have to look at

[PATCH v3 4/4] KVM: x86: Add VCPU substate for event states

2009-11-02 Thread Jan Kiszka
This new substate exports all yet user-invisible states related to exceptions, interrupts, and NMIs. Together with appropriate user space changes, this fixes sporadic problems of vmsave/restore, live migration and system reset. Signed-off-by: Jan Kiszka jan.kis...@siemens.com ---