Re: [PATCH v4 07/13] ARM: KVM: VGIC virtual CPU interface management

2012-12-03 Thread Marc Zyngier
On 03/12/12 14:34, Will Deacon wrote: > On Mon, Dec 03, 2012 at 02:11:03PM +, Marc Zyngier wrote: >> On 03/12/12 13:23, Will Deacon wrote: +#define VGIC_HCR_EN(1 << 0) +#define VGIC_HCR_UIE (1 << 1) + +#define VGIC_LR_VIRTUALID (0x3ff << 0) >>

Re: [PATCH v4 07/13] ARM: KVM: VGIC virtual CPU interface management

2012-12-03 Thread Christoffer Dall
[...] > >>> + >>> + clear_bit(c, &sources); >>> + } >>> + >>> + if (!sources) >>> + clear_bit(i, pending); >> >> What does this signify and how does it happen? An SGI without a source >> sounds pretty weird... > > See the clea

Re: [PATCH v4 07/13] ARM: KVM: VGIC virtual CPU interface management

2012-12-03 Thread Will Deacon
On Mon, Dec 03, 2012 at 02:11:03PM +, Marc Zyngier wrote: > On 03/12/12 13:23, Will Deacon wrote: > >> > >> +#define VGIC_HCR_EN(1 << 0) > >> +#define VGIC_HCR_UIE (1 << 1) > >> + > >> +#define VGIC_LR_VIRTUALID (0x3ff << 0) > >> +#define VGIC_LR_PHYSID_CPUID (7 <<

Re: [PATCH v4 07/13] ARM: KVM: VGIC virtual CPU interface management

2012-12-03 Thread Marc Zyngier
On 03/12/12 13:23, Will Deacon wrote: > Hi Marc, > > I've managed to look at some more of the vgic code, so here is some more > feedback. I've still not got to the end of the series, but there's light at > the end of the tunnel... > > On Sat, Nov 10, 2012 at 03:45:05PM +, Christoffer Dall wro

Re: [PATCH v4 07/13] ARM: KVM: VGIC virtual CPU interface management

2012-12-03 Thread Will Deacon
Hi Marc, I've managed to look at some more of the vgic code, so here is some more feedback. I've still not got to the end of the series, but there's light at the end of the tunnel... On Sat, Nov 10, 2012 at 03:45:05PM +, Christoffer Dall wrote: > From: Marc Zyngier > > Add VGIC virtual CPU

[PATCH v4 07/13] ARM: KVM: VGIC virtual CPU interface management

2012-11-10 Thread Christoffer Dall
From: Marc Zyngier Add VGIC virtual CPU interface code, picking pending interrupts from the distributor and stashing them in the VGIC control interface list registers. Signed-off-by: Marc Zyngier Signed-off-by: Christoffer Dall --- arch/arm/include/asm/kvm_vgic.h | 41 +++ arch/arm/kvm/