Re: [PATCH v5 07/14] KVM: ARM: World-switch implementation

2013-01-16 Thread Gleb Natapov
On Tue, Jan 15, 2013 at 11:08:24PM -0500, Christoffer Dall wrote: On Tue, Jan 15, 2013 at 9:08 PM, Christoffer Dall c.d...@virtualopensystems.com wrote: On Tue, Jan 15, 2013 at 4:43 AM, Gleb Natapov g...@redhat.com wrote: On Tue, Jan 08, 2013 at 01:39:24PM -0500, Christoffer Dall wrote:

Re: [PATCH v5 07/14] KVM: ARM: World-switch implementation

2013-01-16 Thread Russell King - ARM Linux
If you're going to bother commenting on a big long email, please _CHOP OUT_ content which is not relevant to your reply. I paged down 5 pages, hit end, paged up, found no comment from you, so I'm not going to bother reading anything further in this message. Help your readers to read your email.

Re: [PATCH v5 07/14] KVM: ARM: World-switch implementation

2013-01-16 Thread Christoffer Dall
[...] Agree. Lets merge it and change later. The vcpu run loop is simple enough at this point. The question of using vcpu-requests is not the question of real benefit though, of course you can introduce your own mechanism to pass requests to vcpus instead of using whatever kvm provides

Re: [PATCH v5 07/14] KVM: ARM: World-switch implementation

2013-01-16 Thread Christoffer Dall
[...] read side RCU protects against is the memslots data structure as far as I can see, so the second patch pasted below fixes this for the code that actually accesses this data structure. Many memory related functions that you call access memslots under the hood and assume that locking is

Re: [PATCH v5 07/14] KVM: ARM: World-switch implementation

2013-01-16 Thread Gleb Natapov
On Wed, Jan 16, 2013 at 10:42:02AM -0500, Christoffer Dall wrote: [...] read side RCU protects against is the memslots data structure as far as I can see, so the second patch pasted below fixes this for the code that actually accesses this data structure. Many memory related functions

Re: [PATCH v5 07/14] KVM: ARM: World-switch implementation

2013-01-16 Thread Christoffer Dall
On Wed, Jan 16, 2013 at 10:52 AM, Gleb Natapov g...@redhat.com wrote: On Wed, Jan 16, 2013 at 10:42:02AM -0500, Christoffer Dall wrote: [...] read side RCU protects against is the memslots data structure as far as I can see, so the second patch pasted below fixes this for the code that

Re: [PATCH v5 07/14] KVM: ARM: World-switch implementation

2013-01-16 Thread Gleb Natapov
On Wed, Jan 16, 2013 at 10:40:37AM -0500, Christoffer Dall wrote: [...] Agree. Lets merge it and change later. The vcpu run loop is simple enough at this point. The question of using vcpu-requests is not the question of real benefit though, of course you can introduce your own

Re: [PATCH v5 07/14] KVM: ARM: World-switch implementation

2013-01-16 Thread Gleb Natapov
On Wed, Jan 16, 2013 at 11:17:06AM -0500, Christoffer Dall wrote: On Wed, Jan 16, 2013 at 10:52 AM, Gleb Natapov g...@redhat.com wrote: On Wed, Jan 16, 2013 at 10:42:02AM -0500, Christoffer Dall wrote: [...] read side RCU protects against is the memslots data structure as far as I

Re: [PATCH v5 07/14] KVM: ARM: World-switch implementation

2013-01-15 Thread Gleb Natapov
On Tue, Jan 08, 2013 at 01:39:24PM -0500, Christoffer Dall wrote: Provides complete world-switch implementation to switch to other guests running in non-secure modes. Includes Hyp exception handlers that capture necessary exception information and stores the information on the VCPU and KVM

Re: [PATCH v5 07/14] KVM: ARM: World-switch implementation

2013-01-15 Thread Christoffer Dall
On Tue, Jan 15, 2013 at 4:43 AM, Gleb Natapov g...@redhat.com wrote: On Tue, Jan 08, 2013 at 01:39:24PM -0500, Christoffer Dall wrote: Provides complete world-switch implementation to switch to other guests running in non-secure modes. Includes Hyp exception handlers that capture necessary

Re: [PATCH v5 07/14] KVM: ARM: World-switch implementation

2013-01-15 Thread Christoffer Dall
On Tue, Jan 15, 2013 at 9:08 PM, Christoffer Dall c.d...@virtualopensystems.com wrote: On Tue, Jan 15, 2013 at 4:43 AM, Gleb Natapov g...@redhat.com wrote: On Tue, Jan 08, 2013 at 01:39:24PM -0500, Christoffer Dall wrote: Provides complete world-switch implementation to switch to other guests

[PATCH v5 07/14] KVM: ARM: World-switch implementation

2013-01-08 Thread Christoffer Dall
Provides complete world-switch implementation to switch to other guests running in non-secure modes. Includes Hyp exception handlers that capture necessary exception information and stores the information on the VCPU and KVM structures. The following Hyp-ABI is also documented in the code: