Re: [PATCH v5 4/9] KVM-HV: KVM Steal time implementation

2011-07-11 Thread Avi Kivity
On 07/07/2011 08:07 PM, Glauber Costa wrote: +static void record_steal_time(struct kvm_vcpu *vcpu) +{ +u64 delta; + +if (!(vcpu-arch.st.msr_val KVM_MSR_ENABLED)) +return; + +if (unlikely(kvm_read_guest_cached(vcpu-kvm,vcpu-arch.st.stime, + vcpu-arch.st.steal, sizeof(struct

Re: [PATCH v5 4/9] KVM-HV: KVM Steal time implementation

2011-07-11 Thread Avi Kivity
On 07/04/2011 06:32 PM, Glauber Costa wrote: To implement steal time, we need the hypervisor to pass the guest information about how much time was spent running other processes outside the VM, while the vcpu had meaningful work to do - halt time does not count. This information is acquired

Re: [PATCH v5 4/9] KVM-HV: KVM Steal time implementation

2011-07-11 Thread Avi Kivity
On 07/11/2011 04:10 PM, Avi Kivity wrote: I think Peter acked this, yes? Please include his acks. Sorry, I meant this for the kernel/sched.c bits. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. -- To unsubscribe from this list: send

Re: [PATCH v5 4/9] KVM-HV: KVM Steal time implementation

2011-07-11 Thread Glauber Costa
On 07/11/2011 10:11 AM, Avi Kivity wrote: On 07/11/2011 04:10 PM, Avi Kivity wrote: I think Peter acked this, yes? Please include his acks. Sorry, I meant this for the kernel/sched.c bits. Yes he did, after I posted the patches. I will include his acks in the respin, since they won't

Re: [PATCH v5 4/9] KVM-HV: KVM Steal time implementation

2011-07-11 Thread Glauber Costa
On 07/11/2011 09:58 AM, Avi Kivity wrote: On 07/07/2011 08:07 PM, Glauber Costa wrote: +static void record_steal_time(struct kvm_vcpu *vcpu) +{ + u64 delta; + + if (!(vcpu-arch.st.msr_val KVM_MSR_ENABLED)) + return; + + if (unlikely(kvm_read_guest_cached(vcpu-kvm,vcpu-arch.st.stime, +

Re: [PATCH v5 4/9] KVM-HV: KVM Steal time implementation

2011-07-07 Thread Marcelo Tosatti
On Mon, Jul 04, 2011 at 11:32:23AM -0400, Glauber Costa wrote: To implement steal time, we need the hypervisor to pass the guest information about how much time was spent running other processes outside the VM, while the vcpu had meaningful work to do - halt time does not count. This

Re: [PATCH v5 4/9] KVM-HV: KVM Steal time implementation

2011-07-07 Thread Glauber Costa
On 07/07/2011 07:51 AM, Marcelo Tosatti wrote: On Mon, Jul 04, 2011 at 11:32:23AM -0400, Glauber Costa wrote: To implement steal time, we need the hypervisor to pass the guest information about how much time was spent running other processes outside the VM, while the vcpu had meaningful work to

Re: [PATCH v5 4/9] KVM-HV: KVM Steal time implementation

2011-07-06 Thread Rik van Riel
On 07/04/2011 11:32 AM, Glauber Costa wrote: To implement steal time, we need the hypervisor to pass the guest information about how much time was spent running other processes outside the VM, while the vcpu had meaningful work to do - halt time does not count. This information is acquired

Re: [PATCH v5 4/9] KVM-HV: KVM Steal time implementation

2011-07-05 Thread Eric B Munson
On Mon, 04 Jul 2011, Glauber Costa wrote: To implement steal time, we need the hypervisor to pass the guest information about how much time was spent running other processes outside the VM, while the vcpu had meaningful work to do - halt time does not count. This information is acquired

[PATCH v5 4/9] KVM-HV: KVM Steal time implementation

2011-07-04 Thread Glauber Costa
To implement steal time, we need the hypervisor to pass the guest information about how much time was spent running other processes outside the VM, while the vcpu had meaningful work to do - halt time does not count. This information is acquired through the run_delay field of delayacct/schedstats