Re: [PATCHv1] kvm guest: fix uninitialized kvmclock read by KVM guest

2013-06-20 Thread Paolo Bonzini
Il 20/06/2013 10:30, Igor Mammedov ha scritto: On Wed, 19 Jun 2013 15:29:31 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 19/06/2013 15:20, Batalov Eugene ha scritto: I've missed this detail. It looks like Igor's patch doesn't bring secondary cpus kvm_clocksource behavior back to one

Re: [PATCHv1] kvm guest: fix uninitialized kvmclock read by KVM guest

2013-06-20 Thread Igor Mammedov
On Wed, 19 Jun 2013 15:29:31 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 19/06/2013 15:20, Batalov Eugene ha scritto: I've missed this detail. It looks like Igor's patch doesn't bring secondary cpus kvm_clocksource behavior back to one before the regression, Before the regression

Re: [PATCHv1] kvm guest: fix uninitialized kvmclock read by KVM guest

2013-06-19 Thread Paolo Bonzini
Il 19/06/2013 00:21, Marcelo Tosatti ha scritto: On Sat, Jun 15, 2013 at 10:01:45PM +0400, Eugene Batalov wrote: Due to unintialized kvmclock read KVM guest is hanging on SMP boot stage. If unintialized memory contains fatal garbage then hang reproduction is 100%. Unintialized memory is

Re: [PATCHv1] kvm guest: fix uninitialized kvmclock read by KVM guest

2013-06-19 Thread Paolo Bonzini
Il 19/06/2013 15:20, Batalov Eugene ha scritto: I've missed this detail. It looks like Igor's patch doesn't bring secondary cpus kvm_clocksource behavior back to one before the regression, Before the regression per_cpu variables are used to allocate kvm_pv_clock areas. To to usage of percpu

Re: [PATCHv1] kvm guest: fix uninitialized kvmclock read by KVM guest

2013-06-18 Thread Marcelo Tosatti
On Sat, Jun 15, 2013 at 10:01:45PM +0400, Eugene Batalov wrote: Due to unintialized kvmclock read KVM guest is hanging on SMP boot stage. If unintialized memory contains fatal garbage then hang reproduction is 100%. Unintialized memory is allocated by memblock_alloc. So the garbage values

[PATCHv1] kvm guest: fix uninitialized kvmclock read by KVM guest

2013-06-15 Thread Eugene Batalov
Due to unintialized kvmclock read KVM guest is hanging on SMP boot stage. If unintialized memory contains fatal garbage then hang reproduction is 100%. Unintialized memory is allocated by memblock_alloc. So the garbage values depend on many many things. See the detailed description of the bug and