Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-09-26 Thread Michael S. Tsirkin
On Tue, Sep 21, 2010 at 10:27:45AM +0200, xming wrote: Newer versions of dhclient should also be OK: they detect that checksum is missing in the packet. Try it e.g. with a recent fedora guest as a client. I don't have fedora, but with the latest release (4.1.1-P1) on isc.org it still

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-09-21 Thread xming
Newer versions of dhclient should also be OK: they detect that checksum is missing in the packet. Try it e.g. with a recent fedora guest as a client. I don't have fedora, but with the latest release (4.1.1-P1) on isc.org it still behaves the same (see output at the bottom). To solve the

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-09-20 Thread xming
Hi, I think I am hitting this, in a weird way :D. Running 0.12.90, vhost_net and kernel 2.6.35.4, I have troubles to get dhcp clients to work except an old dhcp client pump seems to work out of the box. Below are the output of dhcpcd, isc's dhcp client and busybox' udhcpc. My dhcp server is in a

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-09-20 Thread Michael S. Tsirkin
On Mon, Sep 20, 2010 at 02:12:40PM +0200, xming wrote: Hi, I think I am hitting this, in a weird way :D. Running 0.12.90, vhost_net and kernel 2.6.35.4, I have troubles to get dhcp clients to work except an old dhcp client pump seems to work out of the box. Below are the output of dhcpcd,

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-30 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 29 Jun 2010 16:04:39 +0300 Since using the module involves updating the management tools as well, if we go down this route it will be much less painful for everyone to do push it upstream. Ok, you can make your case to Patrick McHardy and if

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-30 Thread Anthony Liguori
On 06/29/2010 08:04 AM, Michael S. Tsirkin wrote: On Tue, Jun 29, 2010 at 12:36:47AM -0700, David Miller wrote: From: Michael S. Tsirkinm...@redhat.com Date: Mon, 28 Jun 2010 13:08:07 +0300 Userspace virtio server has the following hack so guests rely on it, and we have to replicate

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-30 Thread Michael S. Tsirkin
On Wed, Jun 30, 2010 at 05:08:11PM -0500, Anthony Liguori wrote: On 06/29/2010 08:04 AM, Michael S. Tsirkin wrote: On Tue, Jun 29, 2010 at 12:36:47AM -0700, David Miller wrote: From: Michael S. Tsirkinm...@redhat.com Date: Mon, 28 Jun 2010 13:08:07 +0300 Userspace virtio server has the

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-30 Thread Anthony Liguori
On 06/30/2010 05:31 PM, Michael S. Tsirkin wrote: On Wed, Jun 30, 2010 at 05:08:11PM -0500, Anthony Liguori wrote: On 06/29/2010 08:04 AM, Michael S. Tsirkin wrote: On Tue, Jun 29, 2010 at 12:36:47AM -0700, David Miller wrote: From: Michael S. Tsirkinm...@redhat.com Date:

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-29 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Mon, 28 Jun 2010 13:08:07 +0300 Userspace virtio server has the following hack so guests rely on it, and we have to replicate it, too: Use port number to detect incoming IPv4 DHCP response packets, and fill in the checksum for these. The

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-29 Thread Michael S. Tsirkin
On Tue, Jun 29, 2010 at 12:36:47AM -0700, David Miller wrote: From: Michael S. Tsirkin m...@redhat.com Date: Mon, 28 Jun 2010 13:08:07 +0300 Userspace virtio server has the following hack so guests rely on it, and we have to replicate it, too: Use port number to detect incoming IPv4

[PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-28 Thread Michael S. Tsirkin
Userspace virtio server has the following hack so guests rely on it, and we have to replicate it, too: Use port number to detect incoming IPv4 DHCP response packets, and fill in the checksum for these. The issue we are solving is that on linux guests, some apps that use recvmsg with AF_PACKET

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-28 Thread Michael S. Tsirkin
On Mon, Jun 28, 2010 at 01:08:07PM +0300, Michael S. Tsirkin wrote: Userspace virtio server has the following hack so guests rely on it, and we have to replicate it, too: Use port number to detect incoming IPv4 DHCP response packets, and fill in the checksum for these. The issue we are

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-28 Thread Sridhar Samudrala
On Mon, 2010-06-28 at 13:08 +0300, Michael S. Tsirkin wrote: Userspace virtio server has the following hack so guests rely on it, and we have to replicate it, too: Use port number to detect incoming IPv4 DHCP response packets, and fill in the checksum for these. The issue we are solving