Re: [Qemu-devel] [PULL] Urgent memory fix for kvm with unaligned memory slots

2012-03-02 Thread Anthony Liguori
On 03/01/2012 07:40 AM, Avi Kivity wrote: The memory core may generate RAM memory regions that are not page aligned, but the kvm code is not prepared to handle them well and will abort under certain conditions. This patch fixes the problem. Please pull from: git://git.kernel.org/pub/scm/vir

Re: [Qemu-devel] [PULL] Urgent memory fix for kvm with unaligned memory slots

2012-03-01 Thread Avi Kivity
On 03/01/2012 07:08 PM, Eric Blake wrote: > On 03/01/2012 10:03 AM, Avi Kivity wrote: > >>> > >>> -ram = memory_region_get_ram_ptr(mr) + section->offset_within_region; > >>> +ram = memory_region_get_ram_ptr(mr) + section->offset_within_region > >>> + delta; > >> > >> Am I crazy, or does thi

Re: [Qemu-devel] [PULL] Urgent memory fix for kvm with unaligned memory slots

2012-03-01 Thread Bobby Powers
On Thu, Mar 1, 2012 at 12:08 PM, Eric Blake wrote: > On 03/01/2012 10:03 AM, Avi Kivity wrote: -    ram = memory_region_get_ram_ptr(mr) + section->offset_within_region; +    ram = memory_region_get_ram_ptr(mr) + section->offset_within_region + delta; >>> >>> Am I crazy, or does

Re: [Qemu-devel] [PULL] Urgent memory fix for kvm with unaligned memory slots

2012-03-01 Thread Eric Blake
On 03/01/2012 10:03 AM, Avi Kivity wrote: >>> >>> -ram = memory_region_get_ram_ptr(mr) + section->offset_within_region; >>> +ram = memory_region_get_ram_ptr(mr) + section->offset_within_region >>> + delta; >> >> Am I crazy, or does this look wrong? > > Could be both. Why do you thing it i

Re: [PULL] Urgent memory fix for kvm with unaligned memory slots

2012-03-01 Thread Avi Kivity
On 03/01/2012 06:51 PM, Bobby Powers wrote: > > /* kvm works in page size chunks, but the function may be called > >with sub-page size and unaligned start address. */ > > -size = TARGET_PAGE_ALIGN(size); > > -start_addr = TARGET_PAGE_ALIGN(start_addr); > > +delta = TARGET_PA

Re: [PULL] Urgent memory fix for kvm with unaligned memory slots

2012-03-01 Thread Bobby Powers
On Thu, Mar 1, 2012 at 8:40 AM, Avi Kivity wrote: > The memory core may generate RAM memory regions that are not page > aligned, but the kvm code is not prepared to handle them well and will > abort under certain conditions.  This patch fixes the problem. > > Please pull from: > >  git://git.kerne

[PULL] Urgent memory fix for kvm with unaligned memory slots

2012-03-01 Thread Avi Kivity
The memory core may generate RAM memory regions that are not page aligned, but the kvm code is not prepared to handle them well and will abort under certain conditions. This patch fixes the problem. Please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent ---