Re: [Qemu-devel] [PATCH 21/24] isa: add isa_address_space()

2011-08-10 Thread Richard Henderson
On 08/08/2011 10:07 AM, Avi Kivity wrote: A helper that returns the address space used by ISA devices. Useful for getting rid of isa_mem_base, multiple ISA buses, or ISA buses behind bridges. Signed-off-by: Avi Kivity a...@redhat.com --- hw/isa-bus.c |6 ++ hw/isa.h |1 +

Re: [Qemu-devel] [PATCH 21/24] isa: add isa_address_space()

2011-08-10 Thread Richard Henderson
On 08/10/2011 09:24 AM, Richard Henderson wrote: Of course, as far as I can see, this variable is only used by the VGA devices. Surely we can arrange to pass down some address space during setup of the VGA? ... Which seems to be what you've done in patch 23. So what's the point of this

Re: [Qemu-devel] [PATCH 21/24] isa: add isa_address_space()

2011-08-10 Thread Avi Kivity
On 08/10/2011 07:24 PM, Richard Henderson wrote: @@ -202,4 +203,9 @@ static char *isabus_get_fw_dev_path(DeviceState *dev) return strdup(path); } +MemoryRegion *isa_address_space(ISADevice *dev) +{ +return get_system_memory(); +} + This does not help get rid of

Re: [Qemu-devel] [PATCH 21/24] isa: add isa_address_space()

2011-08-10 Thread Avi Kivity
On 08/10/2011 07:26 PM, Richard Henderson wrote: On 08/10/2011 09:24 AM, Richard Henderson wrote: Of course, as far as I can see, this variable is only used by the VGA devices. Surely we can arrange to pass down some address space during setup of the VGA? ... Which seems to be what

Re: [Qemu-devel] [PATCH 21/24] isa: add isa_address_space()

2011-08-10 Thread Avi Kivity
On 08/10/2011 07:35 PM, Avi Kivity wrote: On 08/10/2011 07:26 PM, Richard Henderson wrote: On 08/10/2011 09:24 AM, Richard Henderson wrote: Of course, as far as I can see, this variable is only used by the VGA devices. Surely we can arrange to pass down some address space during setup of

Re: [Qemu-devel] [PATCH 21/24] isa: add isa_address_space()

2011-08-10 Thread Avi Kivity
On 08/10/2011 07:26 PM, Richard Henderson wrote: On 08/10/2011 09:24 AM, Richard Henderson wrote: Of course, as far as I can see, this variable is only used by the VGA devices. Surely we can arrange to pass down some address space during setup of the VGA? ... Which seems to be what