Hi,
There are 7 sources still call basename() directly and block/vvfat.c
define its own static basename() function. Please see the grep below:
➜ qemu git:(patch-v4) ✗ grep "basename(" **/*.c | grep -v get_basename
fsdev/virtfs-proxy-helper.c:basename(prog));
hw/vfio/pci.c:
On Sat, Oct 03, 2015 at 12:44:14PM +0800, Houcheng Lin wrote:
> diff --git a/configure b/configure
> index d7c24cd..cda88c1 100755
> --- a/configure
> +++ b/configure
> @@ -567,7 +567,6 @@ fi
>
> # host *BSD for user mode
> HOST_VARIANT_DIR=""
> -
> case $targetos in
> CYGWIN*)
>
Just a couple comments since I reviewed the previous versions...
On 06/10/2015 11:47, Stefan Hajnoczi wrote:
> > #include
> > -#include
> > #include
> > #include
> > #include
>
> What is the justification for this? Do you know why io.h was included
> before?
No reason, the same patch
On 10/06/2015 03:47 AM, Stefan Hajnoczi wrote:
> On Sat, Oct 03, 2015 at 12:44:14PM +0800, Houcheng Lin wrote:
>> diff --git a/configure b/configure
>> index d7c24cd..cda88c1 100755
>> +++ b/include/qemu/osdep.h
>> @@ -74,6 +74,14 @@ typedef unsigned intuint_fast16_t;
>> typedef
On 06/10/2015 14:13, Eric Blake wrote:
>
> If you are already writing code to be ported to both Unixy and
> windows systems, you are better off rolling your own alternative to
> basename (or better, using something else that has already rolled a
> portable version for you - while I know gnulib
