Re: [RESEND PATCH] virtio-net: init link state correctly

2010-11-10 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 09:41:27AM +1030, Rusty Russell wrote: On Fri, 5 Nov 2010 08:17:18 pm Jason Wang wrote: For device that supports VIRTIO_NET_F_STATUS, there's no need to assume the link is up and we need to call nerif_carrier_off() before querying device status, otherwise we may get

Re: [RESEND PATCH] virtio-net: init link state correctly

2010-11-10 Thread Rusty Russell
On Thu, 11 Nov 2010 01:38:23 am Michael S. Tsirkin wrote: On Mon, Nov 08, 2010 at 09:41:27AM +1030, Rusty Russell wrote: On Fri, 5 Nov 2010 08:17:18 pm Jason Wang wrote: For device that supports VIRTIO_NET_F_STATUS, there's no need to assume the link is up and we need to call

Re: [RESEND PATCH] virtio-net: init link state correctly

2010-11-07 Thread Rusty Russell
On Fri, 5 Nov 2010 08:17:18 pm Jason Wang wrote: For device that supports VIRTIO_NET_F_STATUS, there's no need to assume the link is up and we need to call nerif_carrier_off() before querying device status, otherwise we may get wrong operstate after diver was loaded because the link watch

[RESEND PATCH] virtio-net: init link state correctly

2010-11-05 Thread Jason Wang
For device that supports VIRTIO_NET_F_STATUS, there's no need to assume the link is up and we need to call nerif_carrier_off() before querying device status, otherwise we may get wrong operstate after diver was loaded because the link watch event was not fired as expected. For device that does