Re: [RFC/PATCH] virtio-console: wait for console ports

2011-09-22 Thread Amit Shah
Hi Christian, On (Wed) 21 Sep 2011 [17:52:23], Christian Borntraeger wrote: Amit, can you have a look at the patch below and give feedback or apply if appropriate? The patch looks good. Just a couple of comments: On s390 I have seen some random Warning: unable to open an initial console

Re: [RFC/PATCH] virtio-console: wait for console ports

2011-09-22 Thread Christian Borntraeger
On 22/09/11 12:08, Amit Shah wrote: +/* If there was an early virtio console, assume that there are no + * other consoles. We need to wait until the hvc_alloc matches the + * hvc_instantiate, otherwise tty_open will complain, resulting in + * a Warning: unable to open an

Re: [RFC/PATCH] virtio-console: wait for console ports

2011-09-22 Thread Amit Shah
On (Thu) 22 Sep 2011 [13:20:07], Christian Borntraeger wrote: On 22/09/11 12:08, Amit Shah wrote: + /* If there was an early virtio console, assume that there are no + * other consoles. We need to wait until the hvc_alloc matches the + * hvc_instantiate, otherwise tty_open will

[RFC/PATCH] virtio-console: wait for console ports

2011-09-21 Thread Christian Borntraeger
Amit, can you have a look at the patch below and give feedback or apply if appropriate? --- On s390 I have seen some random Warning: unable to open an initial console boot failure. Turns out that tty_open fails, because the hvc_alloc was not yet done. In former times this could not happen, since