Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-12-02 Thread Stuart Yoder
On Thu, Dec 1, 2011 at 3:25 PM, Alex Williamson alex.william...@redhat.com wrote: On Thu, 2011-12-01 at 14:58 -0600, Stuart Yoder wrote: One other mechanism we need as well is the ability to enable/disable a domain. For example-- suppose a device is assigned to a VM, the device is in use

RE: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-12-02 Thread Bhushan Bharat-R65777
; joerg.roe...@amd.com; konrad.w...@oracle.com; ag...@suse.de; d...@au1.ibm.com; chrisw@sous- sol.org; Yoder Stuart-B08248; io...@lists.linux-foundation.org; a...@redhat.com; linux-...@vger.kernel.org; Wood Scott-B07421; be...@cisco.com Subject: Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-12-02 Thread Scott Wood
On 12/02/2011 08:40 AM, Stuart Yoder wrote: On Thu, Dec 1, 2011 at 3:25 PM, Alex Williamson alex.william...@redhat.com wrote: On Thu, 2011-12-01 at 14:58 -0600, Stuart Yoder wrote: One other mechanism we need as well is the ability to enable/disable a domain. For example-- suppose a device

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-12-02 Thread Scott Wood
On 12/02/2011 12:11 PM, Bhushan Bharat-R65777 wrote: How do we determine whether guest is ready or not? There can be multiple device get ready at different time. The guest makes a hypercall with a device handle -- at least that's how we do it in Topaz. Further if guest have given the device

RE: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-12-02 Thread Bhushan Bharat-R65777
...@oracle.com; ag...@suse.de; d...@au1.ibm.com; chr...@sous-sol.org; Yoder Stuart-B08248; io...@lists.linux-foundation.org; a...@redhat.com; linux- p...@vger.kernel.org; Wood Scott-B07421; be...@cisco.com Subject: Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework On 12/02/2011 12

RE: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-12-02 Thread Bhushan Bharat-R65777
...@oracle.com; ag...@suse.de; d...@au1.ibm.com; chr...@sous-sol.org; Yoder Stuart-B08248; io...@lists.linux-foundation.org; a...@redhat.com; linux- p...@vger.kernel.org; Wood Scott-B07421; be...@cisco.com Subject: Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework On 12/02/2011 12

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-12-02 Thread Scott Wood
On 12/02/2011 12:45 PM, Bhushan Bharat-R65777 wrote: Scott, I am not sure if there is any real use case where device needed to assigned beyond 2 level (host + immediate guest) in nested virtualization. Userspace drivers in the guest is a more likely scenario than nested virtualization, at

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-12-01 Thread Stuart Yoder
The attributes are not intrinsic features of the domain.  User space will need to set them.  But in thinking about it a bit more I think the attributes are more properties of the domain rather than a per map() operation characteristic.  I think a separate API might be appropriate.  Define a

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-12-01 Thread Alex Williamson
On Thu, 2011-12-01 at 14:58 -0600, Stuart Yoder wrote: The attributes are not intrinsic features of the domain. User space will need to set them. But in thinking about it a bit more I think the attributes are more properties of the domain rather than a per map() operation

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-12-01 Thread Alexey Kardashevskiy
On 29/11/11 16:48, Alex Williamson wrote: On Tue, 2011-11-29 at 15:34 +1100, Alexey Kardashevskiy wrote: Hi! On 29/11/11 14:46, Alex Williamson wrote: On Tue, 2011-11-29 at 12:52 +1100, Alexey Kardashevskiy wrote: Hi! I tried (successfully) to run it on POWER and while doing that I found

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-30 Thread Stuart Yoder
On Tue, Nov 29, 2011 at 5:44 PM, Alex Williamson alex.william...@redhat.com wrote: On Tue, 2011-11-29 at 17:20 -0600, Stuart Yoder wrote: BTW, github now has updated trees: git://github.com/awilliam/linux-vfio.git vfio-next-2029 git://github.com/awilliam/qemu-vfio.git vfio-ng Hi

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-30 Thread Alex Williamson
On Wed, 2011-11-30 at 09:41 -0600, Stuart Yoder wrote: On Tue, Nov 29, 2011 at 5:44 PM, Alex Williamson alex.william...@redhat.com wrote: On Tue, 2011-11-29 at 17:20 -0600, Stuart Yoder wrote: BTW, github now has updated trees: git://github.com/awilliam/linux-vfio.git

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-29 Thread Alex Williamson
On Mon, 2011-11-28 at 20:54 -0700, Alex Williamson wrote: On Tue, 2011-11-29 at 13:01 +1100, Alexey Kardashevskiy wrote: Hi all, Another problem I hit on POWER - MSI interrupts allocation. The existing VFIO does not expect a PBH to support less interrupts that a device might request.

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-29 Thread Stuart Yoder
BTW, github now has updated trees: git://github.com/awilliam/linux-vfio.git vfio-next-2029 git://github.com/awilliam/qemu-vfio.git vfio-ng Hi Alex, Have been looking at vfio a bit. A few observations and things we'll need to figure out as it relates to the Freescale iommu.

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-29 Thread Alex Williamson
On Tue, 2011-11-29 at 17:20 -0600, Stuart Yoder wrote: BTW, github now has updated trees: git://github.com/awilliam/linux-vfio.git vfio-next-2029 git://github.com/awilliam/qemu-vfio.git vfio-ng Hi Alex, Have been looking at vfio a bit. A few observations and things we'll

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-28 Thread Alexey Kardashevskiy
Hi! I tried (successfully) to run it on POWER and while doing that I found some issues. I'll try to explain them in separate mails. IOMMU domain setup. On POWER, the linux drivers capable of DMA transfer want to know a DMA window, i.e. its start and length in the PHB address space. This comes

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-28 Thread Alexey Kardashevskiy
Hi all, Another problem I hit on POWER - MSI interrupts allocation. The existing VFIO does not expect a PBH to support less interrupts that a device might request. In my case, PHB's limit is 8 interrupts while my test card (10Gb ethernet CXGB3) wants 9. Below are the patches to demonstrate the

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-28 Thread Alexey Kardashevskiy
Hi all again, It was actually the very first problem - endianess :-) I am still not sure what format is better for cached config space or whether we should cache it all. Also, as Benh already mentioned, vfio_virt_init reads a config space to a cache by pci_read_config_dword for the whole space

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-28 Thread Alex Williamson
On Tue, 2011-11-29 at 12:52 +1100, Alexey Kardashevskiy wrote: Hi! I tried (successfully) to run it on POWER and while doing that I found some issues. I'll try to explain them in separate mails. Great! IOMMU domain setup. On POWER, the linux drivers capable of DMA transfer want to know

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-28 Thread Alex Williamson
On Tue, 2011-11-29 at 13:01 +1100, Alexey Kardashevskiy wrote: Hi all, Another problem I hit on POWER - MSI interrupts allocation. The existing VFIO does not expect a PBH to support less interrupts that a device might request. In my case, PHB's limit is 8 interrupts while my test card

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-28 Thread Alexey Kardashevskiy
Hi! On 29/11/11 14:46, Alex Williamson wrote: On Tue, 2011-11-29 at 12:52 +1100, Alexey Kardashevskiy wrote: Hi! I tried (successfully) to run it on POWER and while doing that I found some issues. I'll try to explain them in separate mails. Great! IOMMU domain setup. On POWER, the

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-28 Thread Alex Williamson
On Tue, 2011-11-29 at 15:34 +1100, Alexey Kardashevskiy wrote: Hi! On 29/11/11 14:46, Alex Williamson wrote: On Tue, 2011-11-29 at 12:52 +1100, Alexey Kardashevskiy wrote: Hi! I tried (successfully) to run it on POWER and while doing that I found some issues. I'll try to explain

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-22 Thread Alex Williamson
On Mon, 2011-11-21 at 13:47 +1100, David Gibson wrote: On Fri, Nov 18, 2011 at 01:32:56PM -0700, Alex Williamson wrote: On Thu, 2011-11-17 at 11:02 +1100, David Gibson wrote: On Tue, Nov 15, 2011 at 11:01:28AM -0700, Alex Williamson wrote: On Tue, 2011-11-15 at 17:34 +1100, David Gibson

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-22 Thread Alex Williamson
On Fri, Nov 18, 2011 at 2:09 PM, Scott Wood scottw...@freescale.com wrote: On Fri, Nov 18, 2011 at 01:32:56PM -0700, Alex Williamson wrote: Hmm, that might be cleaner than eliminating the size with just using _IO().  So we might have something like: #define VFIO_IOMMU_MAP_DMA              

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-22 Thread Scott Wood
On 11/22/2011 01:16 PM, Alex Williamson wrote: On Fri, Nov 18, 2011 at 2:09 PM, Scott Wood scottw...@freescale.com wrote: On Fri, Nov 18, 2011 at 01:32:56PM -0700, Alex Williamson wrote: Ugh, I suppose you're thinking of an ILP64 platform with ILP32 compat mode. Does Linux support ILP64?

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-11-22 Thread Alex Williamson
On Tue, 2011-11-22 at 14:00 -0600, Scott Wood wrote: On 11/22/2011 01:16 PM, Alex Williamson wrote: On Fri, Nov 18, 2011 at 2:09 PM, Scott Wood scottw...@freescale.com wrote: On Fri, Nov 18, 2011 at 01:32:56PM -0700, Alex Williamson wrote: Ugh, I suppose you're thinking of an ILP64 platform

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-20 Thread David Gibson
On Fri, Nov 18, 2011 at 01:32:56PM -0700, Alex Williamson wrote: On Thu, 2011-11-17 at 11:02 +1100, David Gibson wrote: On Tue, Nov 15, 2011 at 11:01:28AM -0700, Alex Williamson wrote: On Tue, 2011-11-15 at 17:34 +1100, David Gibson wrote: On Thu, Nov 03, 2011 at 02:12:24PM -0600, Alex

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-18 Thread Alex Williamson
On Thu, 2011-11-17 at 11:02 +1100, David Gibson wrote: On Tue, Nov 15, 2011 at 11:01:28AM -0700, Alex Williamson wrote: On Tue, 2011-11-15 at 17:34 +1100, David Gibson wrote: On Thu, Nov 03, 2011 at 02:12:24PM -0600, Alex Williamson wrote: snip +Groups, Devices, IOMMUs, oh my

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-18 Thread Scott Wood
On Fri, Nov 18, 2011 at 01:32:56PM -0700, Alex Williamson wrote: Hmm, that might be cleaner than eliminating the size with just using _IO(). So we might have something like: #define VFIO_IOMMU_MAP_DMA _IOWR(';', 106, struct vfio_dma_map) #define VFIO_IOMMU_MAP_DMA_V2

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-17 Thread Alex Williamson
On Wed, 2011-11-16 at 11:52 -0500, Konrad Rzeszutek Wilk wrote: On Fri, Nov 11, 2011 at 03:10:56PM -0700, Alex Williamson wrote: snip + +Regions are described by a struct vfio_region_info, which is retrieved by +using the GET_REGION_INFO ioctl with vfio_region_info.index field

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-17 Thread Alex Williamson
On Wed, 2011-11-16 at 11:47 -0600, Scott Wood wrote: On 11/11/2011 04:10 PM, Alex Williamson wrote: Thanks Konrad! Comments inline. On Fri, 2011-11-11 at 12:51 -0500, Konrad Rzeszutek Wilk wrote: On Thu, Nov 03, 2011 at 02:12:24PM -0600, Alex Williamson wrote: +When supported, as

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-17 Thread Scott Wood
On Thu, Nov 17, 2011 at 01:22:17PM -0700, Alex Williamson wrote: On Wed, 2011-11-16 at 11:52 -0500, Konrad Rzeszutek Wilk wrote: On Fri, Nov 11, 2011 at 03:10:56PM -0700, Alex Williamson wrote: What would be the return value if somebody tried to unmask an edge one? Should that be documented

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-16 Thread Konrad Rzeszutek Wilk
On Fri, Nov 11, 2011 at 03:10:56PM -0700, Alex Williamson wrote: Thanks Konrad! Comments inline. On Fri, 2011-11-11 at 12:51 -0500, Konrad Rzeszutek Wilk wrote: On Thu, Nov 03, 2011 at 02:12:24PM -0600, Alex Williamson wrote: VFIO provides a secure, IOMMU based interface for user space

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-16 Thread Scott Wood
On 11/11/2011 04:10 PM, Alex Williamson wrote: Thanks Konrad! Comments inline. On Fri, 2011-11-11 at 12:51 -0500, Konrad Rzeszutek Wilk wrote: On Thu, Nov 03, 2011 at 02:12:24PM -0600, Alex Williamson wrote: +When supported, as indicated by the device flags, reset the device. + +#define

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-16 Thread Alex Williamson
On Tue, 2011-11-15 at 16:29 -0600, Scott Wood wrote: On 11/15/2011 03:40 PM, Aaron Fabbri wrote: On 11/15/11 12:10 PM, Scott Wood scottw...@freescale.com wrote: On 11/15/2011 12:34 AM, David Gibson wrote: snip +static int allow_unsafe_intrs;

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-16 Thread David Gibson
On Tue, Nov 15, 2011 at 11:01:28AM -0700, Alex Williamson wrote: On Tue, 2011-11-15 at 17:34 +1100, David Gibson wrote: On Thu, Nov 03, 2011 at 02:12:24PM -0600, Alex Williamson wrote: diff --git a/Documentation/vfio.txt b/Documentation/vfio.txt new file mode 100644 index

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-15 Thread Alex Williamson
On Tue, 2011-11-15 at 17:34 +1100, David Gibson wrote: On Thu, Nov 03, 2011 at 02:12:24PM -0600, Alex Williamson wrote: diff --git a/Documentation/vfio.txt b/Documentation/vfio.txt new file mode 100644 index 000..5866896 --- /dev/null +++ b/Documentation/vfio.txt @@ -0,0 +1,304 @@

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-15 Thread Scott Wood
On 11/15/2011 12:34 AM, David Gibson wrote: I think we need to pin exactly what MAP_ANY means down better. Now, VFIO is pretty much a lost cause if you can't map any normal process memory page into the IOMMU, so I think the only thing that is really covered is IOVAs. But saying can map any

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-15 Thread Aaron Fabbri
On 11/15/11 12:10 PM, Scott Wood scottw...@freescale.com wrote: On 11/15/2011 12:34 AM, David Gibson wrote: snip +static int allow_unsafe_intrs; +module_param(allow_unsafe_intrs, int, 0); +MODULE_PARM_DESC(allow_unsafe_intrs, +Allow use of IOMMUs which do not support interrupt

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-15 Thread Scott Wood
On 11/15/2011 03:40 PM, Aaron Fabbri wrote: On 11/15/11 12:10 PM, Scott Wood scottw...@freescale.com wrote: On 11/15/2011 12:34 AM, David Gibson wrote: snip +static int allow_unsafe_intrs; +module_param(allow_unsafe_intrs, int, 0); +MODULE_PARM_DESC(allow_unsafe_intrs, +

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread Alex Williamson
On Fri, 2011-11-11 at 18:14 -0600, Scott Wood wrote: On 11/03/2011 03:12 PM, Alex Williamson wrote: +Many modern system now provide DMA and interrupt remapping facilities +to help ensure I/O devices behave within the boundaries they've been +allotted. This includes x86 hardware with AMD-Vi

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread Alex Williamson
On Mon, 2011-11-14 at 13:54 -0700, Alex Williamson wrote: On Fri, 2011-11-11 at 18:14 -0600, Scott Wood wrote: On 11/03/2011 03:12 PM, Alex Williamson wrote: + for (i = 0; i npage; i++, iova += PAGE_SIZE, vaddr += PAGE_SIZE) { + unsigned long pfn = 0; + + ret =

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread Scott Wood
On 11/14/2011 02:54 PM, Alex Williamson wrote: On Fri, 2011-11-11 at 18:14 -0600, Scott Wood wrote: What are the semantics of desired and/or returned dma address? I believe the original intention was that a user could leave dmaaddr clear and let the iommu layer provide an iova address. The

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread Alexander Graf
Am 14.11.2011 um 23:26 schrieb Scott Wood scottw...@freescale.com: On 11/14/2011 02:54 PM, Alex Williamson wrote: On Fri, 2011-11-11 at 18:14 -0600, Scott Wood wrote: What are the semantics of desired and/or returned dma address? I believe the original intention was that a user could

RE: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread Alex Williamson
PATCH] vfio: VFIO Driver core framework On Wed, 2011-11-09 at 18:57 -0600, Christian Benvenuti (benve) wrote: Here are few minor comments on vfio_iommu.c ... Sorry, I've been poking sticks at trying to figure out a clean way to solve the force vfio driver attach problem. Attach o

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread David Gibson
On Fri, Nov 11, 2011 at 03:10:56PM -0700, Alex Williamson wrote: Thanks Konrad! Comments inline. On Fri, 2011-11-11 at 12:51 -0500, Konrad Rzeszutek Wilk wrote: On Thu, Nov 03, 2011 at 02:12:24PM -0600, Alex Williamson wrote: [snip] +The GET_NUM_REGIONS ioctl tells us how many regions the

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread David Gibson
On Mon, Nov 14, 2011 at 03:59:00PM -0700, Alex Williamson wrote: On Fri, 2011-11-11 at 16:22 -0600, Christian Benvenuti (benve) wrote: [snip] - the user either unmaps one specific mapping or 'all of them'. The 'all of them' case would also take care of those cases where the user does

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread Benjamin Herrenschmidt
On Tue, 2011-11-15 at 11:05 +1100, David Gibson wrote: Being strict, or at least enforcing strictness, requires that the infrastructure track all the maps, so that the unmaps can be matching. This is not a natural thing with the data structures you want for all IOMMUs. For example on POWER,

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-14 Thread Alex Williamson
On Mon, 2011-11-14 at 13:54 -0700, Alex Williamson wrote: On Fri, 2011-11-11 at 18:14 -0600, Scott Wood wrote: On 11/03/2011 03:12 PM, Alex Williamson wrote: + int (*get)(void *); + void(*put)(void *); + ssize_t (*read)(void *,

RE: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-11 Thread Alex Williamson
On Wed, 2011-11-09 at 18:57 -0600, Christian Benvenuti (benve) wrote: Here are few minor comments on vfio_iommu.c ... Sorry, I've been poking sticks at trying to figure out a clean way to solve the force vfio driver attach problem. diff --git a/drivers/vfio/vfio_iommu.c

RE: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-11 Thread Christian Benvenuti (benve)
(aafabbri); b08...@freescale.com; b07...@freescale.com; a...@redhat.com; konrad.w...@oracle.com; kvm@vger.kernel.org; qemu-de...@nongnu.org; io...@lists.linux-foundation.org; linux-...@vger.kernel.org Subject: RE: [RFC PATCH] vfio: VFIO Driver core framework On Wed, 2011-11-09 at 18:57 -0600

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-11 Thread Scott Wood
On 11/03/2011 03:12 PM, Alex Williamson wrote: +Many modern system now provide DMA and interrupt remapping facilities +to help ensure I/O devices behave within the boundaries they've been +allotted. This includes x86 hardware with AMD-Vi and Intel VT-d as +well as POWER systems with

RE: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-09 Thread Alex Williamson
; a...@redhat.com; konrad.w...@oracle.com; kvm@vger.kernel.org; qemu-de...@nongnu.org; iommu@lists.linux- foundation.org; linux-...@vger.kernel.org Subject: [RFC PATCH] vfio: VFIO Driver core framework snip diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c new file mode

RE: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-09 Thread Alex Williamson
On Wed, 2011-11-09 at 15:08 -0600, Christian Benvenuti (benve) wrote: snip + +struct vfio_group { + dev_t devt; + unsigned intgroupid; This groupid is returned by the device_group callback you recently added with a separate (not

RE: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-09 Thread Christian Benvenuti (benve)
Here are few minor comments on vfio_iommu.c ... diff --git a/drivers/vfio/vfio_iommu.c b/drivers/vfio/vfio_iommu.c new file mode 100644 index 000..029dae3 --- /dev/null +++ b/drivers/vfio/vfio_iommu.c @@ -0,0 +1,530 @@ +/* + * VFIO: IOMMU DMA mapping support + * + * Copyright (C)

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-08 Thread Aaron Fabbri
I'm going to send out chunks of comments as I go over this stuff. Below I've covered the documentation file and vfio_iommu.c. More comments coming soon... On 11/3/11 1:12 PM, Alex Williamson alex.william...@redhat.com wrote: VFIO provides a secure, IOMMU based interface for user space

Re: [RFC PATCH] vfio: VFIO Driver core framework

2011-11-08 Thread Alex Williamson
On Tue, 2011-11-08 at 20:17 -0800, Aaron Fabbri wrote: I'm going to send out chunks of comments as I go over this stuff. Below I've covered the documentation file and vfio_iommu.c. More comments coming soon... On 11/3/11 1:12 PM, Alex Williamson alex.william...@redhat.com wrote: VFIO