Re: [RFC PATCH 1/3] x86/cpu: Unify CPU family, model, stepping calculation

2015-11-19 Thread Borislav Petkov
On Thu, Nov 19, 2015 at 10:34:07AM +0100, Paolo Bonzini wrote: > Let me know if I should include this patch via the KVM tree. Do you > want it in 4.4? Nah, no need. I'll send the whole pile with your Reviewed-by's to Ingo so that they all go together. I'll run them some more on my boxes first

Re: [RFC PATCH 1/3] x86/cpu: Unify CPU family, model, stepping calculation

2015-11-19 Thread Paolo Bonzini
On 18/11/2015 19:50, Borislav Petkov wrote: > On Wed, Nov 18, 2015 at 12:35:24PM +0100, Paolo Bonzini wrote: >> Yes, exactly. I'm suggesting that the same applies to x86_vendor(). I >> also prefer x86_cpuid_* to x86_*_cpuid because, once you add two >> functions in the same family it's nice

Re: [RFC PATCH 1/3] x86/cpu: Unify CPU family, model, stepping calculation

2015-11-18 Thread Borislav Petkov
On Wed, Nov 18, 2015 at 12:35:24PM +0100, Paolo Bonzini wrote: > Yes, exactly. I'm suggesting that the same applies to x86_vendor(). I > also prefer x86_cpuid_* to x86_*_cpuid because, once you add two > functions in the same family it's nice that they share a prefix. Ok, makes sense: ---

Re: [RFC PATCH 1/3] x86/cpu: Unify CPU family, model, stepping calculation

2015-11-18 Thread Paolo Bonzini
On 18/11/2015 12:28, Borislav Petkov wrote: >> On 14/11/2015 11:37, Borislav Petkov wrote: >>> > > vendor = x86_vendor(); >>> > > - family = x86_family(); >>> > > + family = x86_family_cpuid(); >> > >> > What about renaming x86_vendor() so that this looks like >> > >> > -

Re: [RFC PATCH 1/3] x86/cpu: Unify CPU family, model, stepping calculation

2015-11-18 Thread Borislav Petkov
On Wed, Nov 18, 2015 at 12:10:08PM +0100, Paolo Bonzini wrote: > On 14/11/2015 11:37, Borislav Petkov wrote: > > vendor = x86_vendor(); > > - family = x86_family(); > > + family = x86_family_cpuid(); > > What about renaming x86_vendor() so that this looks like > > - vendor =

Re: [RFC PATCH 1/3] x86/cpu: Unify CPU family, model, stepping calculation

2015-11-18 Thread Paolo Bonzini
On 14/11/2015 11:37, Borislav Petkov wrote: > vendor = x86_vendor(); > - family = x86_family(); > + family = x86_family_cpuid(); What about renaming x86_vendor() so that this looks like - vendor = x86_vendor(); - family = x86_family(); + vendor =

[RFC PATCH 1/3] x86/cpu: Unify CPU family, model, stepping calculation

2015-11-14 Thread Borislav Petkov
From: Borislav Petkov Add generic functions which calc family, model and stepping from the CPUID_1.EAX leaf and stick them into the library we have. No functionality change. Signed-off-by: Borislav Petkov --- arch/x86/include/asm/cpu.h| 3 +++