Re: [RFC PATCH 3/4] KVM: x86: Add EOI exit bitmap inference

2015-05-14 Thread Alex Williamson
On Thu, 2015-05-14 at 15:10 -0700, Steve Rutherford wrote: > On Thu, May 14, 2015 at 10:04:40AM -0600, Alex Williamson wrote: > > On Thu, 2015-05-14 at 17:46 +0200, Paolo Bonzini wrote: > > > > > > On 14/05/2015 17:23, Alex Williamson wrote: > > > > > Would irq_ack_notifiers be used at all with th

Re: [RFC PATCH 3/4] KVM: x86: Add EOI exit bitmap inference

2015-05-13 Thread Jan Kiszka
On 2015-05-13 15:04, Paolo Bonzini wrote: > > > On 13/05/2015 12:25, Jan Kiszka wrote: > But perhaps when enabling KVM_SPLIT_IRQCHIP we can use args[0] to pass > the number of IOAPIC routes that will cause EOI exits? And you need to ensure that their routes can be found in the t

Re: [RFC PATCH 3/4] KVM: x86: Add EOI exit bitmap inference

2015-05-13 Thread Jan Kiszka
On 2015-05-13 11:24, Paolo Bonzini wrote: > > > On 13/05/2015 10:10, Jan Kiszka wrote: >> There can even be multiple IOAPICs (thanks to your patches overcoming >> the single in-kernel instance). With multiple IOAPICs you have more than 24 GSIs per IOAPIC. That means >> I don't

Re: [RFC PATCH 3/4] KVM: x86: Add EOI exit bitmap inference

2015-05-13 Thread Jan Kiszka
On 2015-05-13 10:04, Paolo Bonzini wrote: > > > On 13/05/2015 08:12, Jan Kiszka wrote: >>> +void kvm_scan_ioapic_routes(struct kvm_vcpu *vcpu, u64 *eoi_exit_bitmap) >>> +{ >>> + struct kvm *kvm = vcpu->kvm; >>> + struct kvm_kernel_irq_routing_entry *entry; >>> + struct kvm_irq_routing_table

Re: [RFC PATCH 3/4] KVM: x86: Add EOI exit bitmap inference

2015-05-12 Thread Jan Kiszka
On 2015-05-13 03:47, Steve Rutherford wrote: > In order to support a userspace IOAPIC interacting with an in kernel > APIC, the EOI exit bitmaps need to be configurable. > > If the IOAPIC is in userspace (i.e. the irqchip has been split), the > EOI exit bitmaps will be set whenever the GSI Routes

[RFC PATCH 3/4] KVM: x86: Add EOI exit bitmap inference

2015-05-12 Thread Steve Rutherford
In order to support a userspace IOAPIC interacting with an in kernel APIC, the EOI exit bitmaps need to be configurable. If the IOAPIC is in userspace (i.e. the irqchip has been split), the EOI exit bitmaps will be set whenever the GSI Routes are configured. In particular, for the low 24 MSI route