Re: [RFC PATCH 4/4] vhost_net: byteswap virtio_net header

2014-11-03 Thread Michael S. Tsirkin
On Wed, Oct 29, 2014 at 09:38:45AM +0100, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater c...@fr.ibm.com This patch casts userspace pointers to void *, this is generally unsafe. In particular sparse will warn. --- drivers/vhost/net.c | 39 ++-

Re: [RFC PATCH 4/4] vhost_net: byteswap virtio_net header

2014-11-03 Thread Michael S. Tsirkin
On Wed, Oct 29, 2014 at 09:38:45AM +0100, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater c...@fr.ibm.com This patch casts userspace pointers to void *, this is generally unsafe. In particular sparse will warn. --- drivers/vhost/net.c | 39 ++-

[RFC PATCH 4/4] vhost_net: byteswap virtio_net header

2014-10-29 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater c...@fr.ibm.com --- drivers/vhost/net.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 8dae2f724a35..f2d5f585dae9 100644 --- a/drivers/vhost/net.c +++

[RFC PATCH 4/4] vhost_net: byteswap virtio_net header

2014-10-29 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater c...@fr.ibm.com --- drivers/vhost/net.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 8dae2f724a35..f2d5f585dae9 100644 --- a/drivers/vhost/net.c +++