Re: [SeaBIOS] [PATCH v2] add acpi pmtimer support

2012-09-05 Thread Gerd Hoffmann
Hi, +u32 pmtimer = inl(ioport); +return (u64)wraps << 24 | pmtimer; >>> BTW, why is this "<< 24", and if it should be that way, shouldn't the >>> pmtimer be "inl(ioport) & 0xff" ? >> The pmtimer is defined to be 24 bits wide, so the shift is correct. > This is not true in g

Re: [SeaBIOS] [PATCH v2] add acpi pmtimer support

2012-09-05 Thread Don Slutz
On 09/05/12 01:27, Gerd Hoffmann wrote: On 09/02/12 22:42, Kevin O'Connor wrote: On Tue, Aug 14, 2012 at 07:29:19AM +0200, Gerd Hoffmann wrote: This patch makes seabios use the acpi pmtimer instead of tsc for timekeeping. The pmtimer has a fixed frequency and doesn't need calibration, thus it