Re: [net-next PATCH 1/2] igbvf: add new driver to support 82576 virtual functions

2009-03-18 Thread Alexander Duyck
Andrew Morton wrote: On Tue, 17 Mar 2009 17:12:48 -0700 Alexander Duyck alexander.h.du...@intel.com wrote: Thanks for all the comments. I tried to incorporate most of them into the igbvf driver and also ended up porting some over to our other drivers, specifically igb since the igbvf driver

Re: [net-next PATCH 1/2] igbvf: add new driver to support 82576 virtual functions

2009-03-18 Thread Andrew Morton
On Wed, 18 Mar 2009 08:22:46 -0700 Alexander Duyck alexander.h.du...@intel.com wrote: +static int igbvf_set_ringparam(struct net_device *netdev, + struct ethtool_ringparam *ring) +{ + struct igbvf_adapter *adapter = netdev_priv(netdev); + struct

Re: [net-next PATCH 1/2] igbvf: add new driver to support 82576 virtual functions

2009-03-17 Thread Alexander Duyck
Thanks for all the comments. I tried to incorporate most of them into the igbvf driver and also ended up porting some over to our other drivers, specifically igb since the igbvf driver copies much of the code. I have added my comments inline below. Thanks, Alex Andrew Morton wrote: On

Re: [net-next PATCH 1/2] igbvf: add new driver to support 82576 virtual functions

2009-03-10 Thread Andrew Morton
On Tue, 10 Mar 2009 19:09:28 -0700 Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: From: Alexander Duyck alexander.h.du...@intel.com This adds an igbvf driver to handle virtual functions provided by the igb driver. The drive-by reader is now wondering what a virtual function is. ...