[patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines

2011-12-08 Thread Carsten Otte
This patch introduces a new config option for user controlled kernel virtual machines. It introduces an optional parameter to KVM_CREATE_VM in order to create a user controlled virtual machine. The parameter is passed to kvm_arch_init_vm for all architectures. Valid values for the new parameter

Re: [patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines

2011-12-08 Thread Sasha Levin
On Thu, 2011-12-08 at 10:12 +0100, Carsten Otte wrote: plain text document attachment (enable-ucontrol.patch) This patch introduces a new config option for user controlled kernel virtual machines. It introduces an optional parameter to KVM_CREATE_VM in order to create a user controlled virtual

Re: [patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines

2011-12-08 Thread Carsten Otte
On 08.12.2011 10:25, Sasha Levin wrote: Why is it s390 specific? why isn't it KVM_VM_UCONTROL which is currently only implemented on s390? Good point. Maybe the subject line for the patch should be fixed along with that ;-) -- To unsubscribe from this list: send the line unsubscribe kvm in

Re: [patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines

2011-12-08 Thread Avi Kivity
On 12/08/2011 11:25 AM, Sasha Levin wrote: On Thu, 2011-12-08 at 10:12 +0100, Carsten Otte wrote: plain text document attachment (enable-ucontrol.patch) This patch introduces a new config option for user controlled kernel virtual machines. It introduces an optional parameter to

Re: [patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines

2011-12-08 Thread Sasha Levin
On Thu, 2011-12-08 at 11:45 +0200, Avi Kivity wrote: On 12/08/2011 11:25 AM, Sasha Levin wrote: On Thu, 2011-12-08 at 10:12 +0100, Carsten Otte wrote: plain text document attachment (enable-ucontrol.patch) This patch introduces a new config option for user controlled kernel virtual

Re: [patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines

2011-12-08 Thread Avi Kivity
On 12/08/2011 11:53 AM, Sasha Levin wrote: On Thu, 2011-12-08 at 11:45 +0200, Avi Kivity wrote: On 12/08/2011 11:25 AM, Sasha Levin wrote: On Thu, 2011-12-08 at 10:12 +0100, Carsten Otte wrote: plain text document attachment (enable-ucontrol.patch) This patch introduces a new config

Re: [patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines

2011-12-08 Thread Alexander Graf
On 08.12.2011, at 10:59, Avi Kivity a...@redhat.com wrote: On 12/08/2011 11:53 AM, Sasha Levin wrote: On Thu, 2011-12-08 at 11:45 +0200, Avi Kivity wrote: On 12/08/2011 11:25 AM, Sasha Levin wrote: On Thu, 2011-12-08 at 10:12 +0100, Carsten Otte wrote: plain text document attachment

Re: [patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines

2011-12-08 Thread Carsten Otte
On 08.12.2011 11:18, Alexander Graf wrote: If you really have to do this, please 1) make it s390 only. I don't even want to have to see this uglyness in other archs It pretty much is. The only interference is a) checking the machine type in arch_init_vm now that I've introduced that

Re: [patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines

2011-12-08 Thread Alexander Graf
On 12/08/2011 12:48 PM, Carsten Otte wrote: On 08.12.2011 11:18, Alexander Graf wrote: If you really have to do this, please 1) make it s390 only. I don't even want to have to see this uglyness in other archs It pretty much is. The only interference is a) checking the machine type in

[patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines

2011-12-01 Thread Carsten Otte
This patch introduces a new config option for user controlled kernel virtual machines. It introduces a new ioctl named KVM_S390_ENABLE_UCONTROL on the kvm file descriptor which allows for a one way transition from a regular kernel virtual machine to a user controlled virtual machine. The virtual

Re: [patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines

2011-12-01 Thread Avi Kivity
On 12/01/2011 02:57 PM, Carsten Otte wrote: This patch introduces a new config option for user controlled kernel virtual machines. It introduces a new ioctl named KVM_S390_ENABLE_UCONTROL on the kvm file descriptor which allows for a one way transition from a regular kernel virtual machine to

Re: [patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines

2011-12-01 Thread Avi Kivity
On 12/01/2011 03:15 PM, Avi Kivity wrote: + + if (kvm-arch.gmap) + gmap_free(kvm-arch.gmap); + + kvm-arch.gmap = NULL; Locking? What happens if a vcpu is created afterwards? Having read the code, I think you can repurpose the argument of KVM_CREATE_VM to be a vm

Re: [patch 01/12] [PATCH] kvm-s390: ioctl to switch to user controlled virtual machines

2011-12-01 Thread Martin Schwidefsky
On Thu, 01 Dec 2011 15:15:03 +0200 Avi Kivity a...@redhat.com wrote: + + if (kvm-arch.gmap) + gmap_free(kvm-arch.gmap); + + kvm-arch.gmap = NULL; Locking? What happens if a vcpu is created afterwards? I guess you don't mind too much since this is a privileged