Re: Endless loop in qcow2_alloc_cluster_offset

2010-05-07 Thread Marcelo Tosatti
On Fri, May 07, 2010 at 09:37:22AM +0200, Kevin Wolf wrote: > Am 07.05.2010 03:19, schrieb Marcelo Tosatti: > > On Thu, Nov 19, 2009 at 01:19:55PM +0100, Jan Kiszka wrote: > >> Hi, > >> > >> I just managed to push a qemu-kvm process (git rev. b496

Re: Endless loop in qcow2_alloc_cluster_offset

2010-05-07 Thread Kevin Wolf
Am 07.05.2010 03:19, schrieb Marcelo Tosatti: > On Thu, Nov 19, 2009 at 01:19:55PM +0100, Jan Kiszka wrote: >> Hi, >> >> I just managed to push a qemu-kvm process (git rev. b496fe3431) into an >> endless loop in qcow2_alloc_cluster_offset, namely over >> QLIST_FORE

Re: Endless loop in qcow2_alloc_cluster_offset

2010-05-06 Thread Marcelo Tosatti
On Thu, Nov 19, 2009 at 01:19:55PM +0100, Jan Kiszka wrote: > Hi, > > I just managed to push a qemu-kvm process (git rev. b496fe3431) into an > endless loop in qcow2_alloc_cluster_offset, namely over > QLIST_FOREACH(old_alloc, &s->cluster_allocs, next_in_fligh

Re: [Qemu-devel] Re: Endless loop in qcow2_alloc_cluster_offset

2009-12-08 Thread Kevin Wolf
Am 07.12.2009 16:00, schrieb Kevin Wolf: > Am 07.12.2009 15:16, schrieb Jan Kiszka: >>> Likely not. What I did was nothing special, and I did not noticed such a >>> crash in the last months. >> >> And now it happened again (qemu-kvm head, during kernel installation >> from network onto local qcow2-

Re: Endless loop in qcow2_alloc_cluster_offset

2009-12-07 Thread Kevin Wolf
Am 07.12.2009 17:09, schrieb Jan Kiszka: > Kevin Wolf wrote: >> In qcow_aio_write_cb there isn't much happening between these calls. The >> only thing that could somehow become dangerous is the >> qcow_aio_write_cb(req, 0); for queued requests in run_dependent_requests. > > If m->nb_clusters is no

Re: Endless loop in qcow2_alloc_cluster_offset

2009-12-07 Thread Jan Kiszka
Kevin Wolf wrote: > Am 07.12.2009 15:16, schrieb Jan Kiszka: >>> Likely not. What I did was nothing special, and I did not noticed such a >>> crash in the last months. >> And now it happened again (qemu-kvm head, during kernel installation >> from network onto local qcow2-disk). Any clever idea how

Re: Endless loop in qcow2_alloc_cluster_offset

2009-12-07 Thread Jan Kiszka
Kevin Wolf wrote: > Am 07.12.2009 15:50, schrieb Jan Kiszka: >> Jan Kiszka wrote: >>> And now it happened again (qemu-kvm head, during kernel installation >>> from network onto local qcow2-disk). Any clever idea how to proceed with >>> this? >>> >>> I could try to run the step in a loop, hopefully

Re: Endless loop in qcow2_alloc_cluster_offset

2009-12-07 Thread Kevin Wolf
Am 07.12.2009 15:50, schrieb Jan Kiszka: > Jan Kiszka wrote: >> And now it happened again (qemu-kvm head, during kernel installation >> from network onto local qcow2-disk). Any clever idea how to proceed with >> this? >> >> I could try to run the step in a loop, hopefully retriggering it once in >>

Re: Endless loop in qcow2_alloc_cluster_offset

2009-12-07 Thread Avi Kivity
On 12/07/2009 04:50 PM, Jan Kiszka wrote: Maybe I'm seeing ghosts, and I don't even have a minimal clue about what goes on in the code, but this looks fishy: Plenty of ghosts in qcow2, of all those explorers who tried to brave the code. Only Kevin has ever come back. preallocate() in

Re: Endless loop in qcow2_alloc_cluster_offset

2009-12-07 Thread Kevin Wolf
Am 07.12.2009 15:16, schrieb Jan Kiszka: >> Likely not. What I did was nothing special, and I did not noticed such a >> crash in the last months. > > And now it happened again (qemu-kvm head, during kernel installation > from network onto local qcow2-disk). Any clever idea how to proceed with > th

Re: Endless loop in qcow2_alloc_cluster_offset

2009-12-07 Thread Jan Kiszka
Jan Kiszka wrote: > And now it happened again (qemu-kvm head, during kernel installation > from network onto local qcow2-disk). Any clever idea how to proceed with > this? > > I could try to run the step in a loop, hopefully retriggering it once in > a (likely longer) while. But then we need some

Re: Endless loop in qcow2_alloc_cluster_offset

2009-12-07 Thread Jan Kiszka
Jan Kiszka wrote: > Kevin Wolf wrote: >> Hi Jan, >> >> Am 19.11.2009 13:19, schrieb Jan Kiszka: >>> (gdb) print ((BDRVQcowState *)bs->opaque)->cluster_allocs.lh_first >>> $5 = (struct QCowL2Meta *) 0xcb3568 >>> (gdb) print *((BDRVQcowState *)bs->opaque)->cluster_allocs.lh_first >>> $6 = {offset =

Re: Endless loop in qcow2_alloc_cluster_offset

2009-11-19 Thread Jan Kiszka
Kevin Wolf wrote: > Hi Jan, > > Am 19.11.2009 13:19, schrieb Jan Kiszka: >> (gdb) print ((BDRVQcowState *)bs->opaque)->cluster_allocs.lh_first >> $5 = (struct QCowL2Meta *) 0xcb3568 >> (gdb) print *((BDRVQcowState *)bs->opaque)->cluster_allocs.lh_first >> $6 = {offset = 7417176064, n_start = 0,

Re: Endless loop in qcow2_alloc_cluster_offset

2009-11-19 Thread Kevin Wolf
Hi Jan, Am 19.11.2009 13:19, schrieb Jan Kiszka: > (gdb) print ((BDRVQcowState *)bs->opaque)->cluster_allocs.lh_first > $5 = (struct QCowL2Meta *) 0xcb3568 > (gdb) print *((BDRVQcowState *)bs->opaque)->cluster_allocs.lh_first > $6 = {offset = 7417176064, n_start = 0, nb_available = 16, nb_cluste

Endless loop in qcow2_alloc_cluster_offset

2009-11-19 Thread Jan Kiszka
Hi, I just managed to push a qemu-kvm process (git rev. b496fe3431) into an endless loop in qcow2_alloc_cluster_offset, namely over QLIST_FOREACH(old_alloc, &s->cluster_allocs, next_in_flight): (gdb) bt #0 0x0048614b in qcow2_alloc_cluster_offset (bs=0xc4e1d0, offset=741