Re: Indefinite recursion in pci_default_read_config

2009-12-15 Thread Avi Kivity
On 12/15/2009 01:35 PM, Michael S. Tsirkin wrote: Should just be static in fact. Here's a better one: Changelog and signoff please. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message t

Re: Indefinite recursion in pci_default_read_config

2009-12-15 Thread Michael S. Tsirkin
On Tue, Dec 15, 2009 at 12:26:15PM +0100, Hannes Reinecke wrote: > Michael S. Tsirkin wrote: > > On Tue, Dec 15, 2009 at 12:59:41PM +0200, Avi Kivity wrote: > >> On 12/15/2009 12:57 PM, Hannes Reinecke wrote: > >>> Hi all, > >>> > >>

Re: Indefinite recursion in pci_default_read_config

2009-12-15 Thread Hannes Reinecke
Michael S. Tsirkin wrote: > On Tue, Dec 15, 2009 at 12:59:41PM +0200, Avi Kivity wrote: >> On 12/15/2009 12:57 PM, Hannes Reinecke wrote: >>> Hi all, >>> >>> I just triggered a nasty indefinite recursion in pci_default_read_config: >>> >

Re: Indefinite recursion in pci_default_read_config

2009-12-15 Thread Michael S. Tsirkin
On Tue, Dec 15, 2009 at 12:59:41PM +0200, Avi Kivity wrote: > On 12/15/2009 12:57 PM, Hannes Reinecke wrote: >> Hi all, >> >> I just triggered a nasty indefinite recursion in pci_default_read_config: >> >> uint32_t pci_default_read_config(PCIDevice *d, >>

Re: Indefinite recursion in pci_default_read_config

2009-12-15 Thread Avi Kivity
On 12/15/2009 12:57 PM, Hannes Reinecke wrote: Hi all, I just triggered a nasty indefinite recursion in pci_default_read_config: uint32_t pci_default_read_config(PCIDevice *d, uint32_t address, int len) { uint32_t val = 0; assert(len == 1 || len == 2

Indefinite recursion in pci_default_read_config

2009-12-15 Thread Hannes Reinecke
Hi all, I just triggered a nasty indefinite recursion in pci_default_read_config: uint32_t pci_default_read_config(PCIDevice *d, uint32_t address, int len) { uint32_t val = 0; assert(len == 1 || len == 2 || len == 4); if (pci_access_cap_config(d