Re: KVM: MMU: always invalidate and flush on spte page size change

2010-05-31 Thread Avi Kivity
On 05/30/2010 06:19 PM, Marcelo Tosatti wrote: On Sun, May 30, 2010 at 01:28:19PM +0300, Avi Kivity wrote: On 05/28/2010 03:44 PM, Marcelo Tosatti wrote: Always invalidate spte and flush TLBs when changing page size, to make sure different sized translations for the same address are

Re: KVM: MMU: always invalidate and flush on spte page size change

2010-05-30 Thread Avi Kivity
On 05/28/2010 03:44 PM, Marcelo Tosatti wrote: Always invalidate spte and flush TLBs when changing page size, to make sure different sized translations for the same address are never cached in a CPU's TLB. The first case where this occurs is when a non-leaf spte pointer is overwritten by a

Re: KVM: MMU: always invalidate and flush on spte page size change

2010-05-30 Thread Marcelo Tosatti
On Sun, May 30, 2010 at 01:28:19PM +0300, Avi Kivity wrote: On 05/28/2010 03:44 PM, Marcelo Tosatti wrote: Always invalidate spte and flush TLBs when changing page size, to make sure different sized translations for the same address are never cached in a CPU's TLB. The first case where this

KVM: MMU: always invalidate and flush on spte page size change

2010-05-28 Thread Marcelo Tosatti
Always invalidate spte and flush TLBs when changing page size, to make sure different sized translations for the same address are never cached in a CPU's TLB. The first case where this occurs is when a non-leaf spte pointer is overwritten by a leaf, large spte entry. This can happen after dirty