Re: KVM: x86: disable kvmclock on non constant TSC hosts

2009-02-12 Thread Avi Kivity
Chris Wright wrote: Porting is done by stable maintainers if it's trivial, push back to developer/subsytem maintainer if it's not. Testing depends again, in most cases the upstream testing is still valid. If not..."please verify" Warm, fuzzy feeling. -- I have a truly marvellous patch tha

Re: KVM: x86: disable kvmclock on non constant TSC hosts

2009-02-12 Thread Chris Wright
* Avi Kivity (a...@redhat.com) wrote: > Chris Wright wrote: >> * Avi Kivity (a...@redhat.com) wrote: >> >>> Does 'Cc: stable' mean -stable picks it up automatically? That >>> doesn't seem right. >> >> Yes. If you add "Cc: sta...@kernel.org" to the commit message, it will >> get routed to sta

Re: KVM: x86: disable kvmclock on non constant TSC hosts

2009-02-12 Thread Avi Kivity
Chris Wright wrote: * Avi Kivity (a...@redhat.com) wrote: Does 'Cc: stable' mean -stable picks it up automatically? That doesn't seem right. Yes. If you add "Cc: sta...@kernel.org" to the commit message, it will get routed to stable when it's committed upstream (still gets human tou

Re: KVM: x86: disable kvmclock on non constant TSC hosts

2009-02-12 Thread Chris Wright
* Avi Kivity (a...@redhat.com) wrote: > Does 'Cc: stable' mean -stable picks it up automatically? That doesn't > seem right. Yes. If you add "Cc: sta...@kernel.org" to the commit message, it will get routed to stable when it's committed upstream (still gets human touch, it's not automatically

Re: KVM: x86: disable kvmclock on non constant TSC hosts

2009-02-12 Thread Mark McLoughlin
On Thu, 2009-02-12 at 12:02 +0200, Avi Kivity wrote: > Marcelo Tosatti wrote: > > On Wed, Feb 11, 2009 at 08:08:23PM +, Mark McLoughlin wrote: > > > >> On Wed, 2009-02-11 at 14:01 +0200, Avi Kivity wrote: > >> > >>> Marcelo Tosatti wrote: > >>> > This is better. > > >>>

Re: KVM: x86: disable kvmclock on non constant TSC hosts

2009-02-12 Thread Avi Kivity
Marcelo Tosatti wrote: On Wed, Feb 11, 2009 at 08:08:23PM +, Mark McLoughlin wrote: On Wed, 2009-02-11 at 14:01 +0200, Avi Kivity wrote: Marcelo Tosatti wrote: This is better. Currently, this code path is posing us big troubles, and we won't have a decent patch in time. So,

Re: KVM: x86: disable kvmclock on non constant TSC hosts

2009-02-11 Thread Marcelo Tosatti
On Wed, Feb 11, 2009 at 08:08:23PM +, Mark McLoughlin wrote: > On Wed, 2009-02-11 at 14:01 +0200, Avi Kivity wrote: > > Marcelo Tosatti wrote: > > > This is better. > > > > > > Currently, this code path is posing us big troubles, > > > and we won't have a decent patch in time. So, temporarily >

Re: KVM: x86: disable kvmclock on non constant TSC hosts

2009-02-11 Thread Mark McLoughlin
On Wed, 2009-02-11 at 14:01 +0200, Avi Kivity wrote: > Marcelo Tosatti wrote: > > This is better. > > > > Currently, this code path is posing us big troubles, > > and we won't have a decent patch in time. So, temporarily > > disable it. > > > > > > Applied to master and kvm-updates/2.6.29, th

Re: KVM: x86: disable kvmclock on non constant TSC hosts

2009-02-11 Thread Avi Kivity
Marcelo Tosatti wrote: This is better. Currently, this code path is posing us big troubles, and we won't have a decent patch in time. So, temporarily disable it. Applied to master and kvm-updates/2.6.29, thanks. -- error compiling committee.c: too many arguments to function -- To unsubs

KVM: x86: disable kvmclock on non constant TSC hosts

2009-02-10 Thread Marcelo Tosatti
This is better. Currently, this code path is posing us big troubles, and we won't have a decent patch in time. So, temporarily disable it. Signed-off-by: Glauber Costa Signed-off-by: Marcelo Tosatti Index: kvm/arch/x86/kvm/x86.c ===

KVM: x86: disable kvmclock on non constant TSC hosts

2009-02-10 Thread Marcelo Tosatti
Currently, this code path is posing us big troubles, and we won't have a decent patch in time. So, temporarily disable it. There's a module parameter for the adventurous who want to force it. Signed-off-by: Glauber Costa Signed-off-by: Marcelo Tosatti --- arch/x86/kvm/x86.c |7 ++- 1