Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Alexander Graf
On 03.05.2013, at 18:11, Mihai Caraman wrote: A change in the generic code highlighted that we were running with IRQs (soft) enabled on Book3E 64-bit when trying to restart interrupts from handle_exit(). This is a lesson to configure lockdep often :) There is no reason to exit guest with

Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Scott Wood
On 05/03/2013 11:11:10 AM, Mihai Caraman wrote: A change in the generic code highlighted that we were running with IRQs (soft) enabled on Book3E 64-bit when trying to restart interrupts from handle_exit(). This is a lesson to configure lockdep often :) There is no reason to exit guest with

RE: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Caraman Mihai Claudiu-B02008
-Original Message- From: Wood Scott-B07421 Sent: Friday, May 03, 2013 9:05 PM To: Caraman Mihai Claudiu-B02008 Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- d...@lists.ozlabs.org; Caraman Mihai Claudiu-B02008 Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings

Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Scott Wood
-B02008 Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs The unresponsiveness has to do with the fact that arch_local_irq_restore() does not guarantees to hard enable interrupts. Could you elaborate? If the saved IRQ state was enabled, why wouldn't

RE: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Caraman Mihai Claudiu-B02008
-Original Message- From: Wood Scott-B07421 Sent: Friday, May 03, 2013 11:15 PM To: Caraman Mihai Claudiu-B02008 Cc: Wood Scott-B07421; kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc-...@lists.ozlabs.org Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Benjamin Herrenschmidt
On Fri, 2013-05-03 at 18:24 +0200, Alexander Graf wrote: There is no reason to exit guest with soft_enabled == 1, a local_irq_enable() call will do this for us so get rid of kvmppc_layz_ee() calls. With this fix we eliminate irqs_disabled() warnings and some guest and host hangs revealed

Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Scott Wood
: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs The unresponsiveness has to do with the fact that arch_local_irq_restore() does not guarantees to hard enable interrupts. Could you elaborate? If the saved IRQ state was enabled, why wouldn't

RE: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Caraman Mihai Claudiu-B02008
-Original Message- From: Wood Scott-B07421 Sent: Saturday, May 04, 2013 1:07 AM To: Caraman Mihai Claudiu-B02008 Cc: Wood Scott-B07421; kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc-...@lists.ozlabs.org Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Scott Wood
Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs I replaced the two calls to kvmppc_lazy_ee_enable() with calls to hard_irq_disable(), and it seems to be working fine. Please take a look on 'KVM: PPC64: booke: Hard disable interrupts when entering guest' RFC thread and see

Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Alexander Graf
On 03.05.2013, at 18:11, Mihai Caraman wrote: A change in the generic code highlighted that we were running with IRQs (soft) enabled on Book3E 64-bit when trying to restart interrupts from handle_exit(). This is a lesson to configure lockdep often :) There is no reason to exit guest with

Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Scott Wood
On 05/03/2013 11:11:10 AM, Mihai Caraman wrote: A change in the generic code highlighted that we were running with IRQs (soft) enabled on Book3E 64-bit when trying to restart interrupts from handle_exit(). This is a lesson to configure lockdep often :) There is no reason to exit guest with

RE: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Caraman Mihai Claudiu-B02008
-Original Message- From: Wood Scott-B07421 Sent: Friday, May 03, 2013 9:05 PM To: Caraman Mihai Claudiu-B02008 Cc: kvm-ppc@vger.kernel.org; k...@vger.kernel.org; linuxppc- d...@lists.ozlabs.org; Caraman Mihai Claudiu-B02008 Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings

Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Scott Wood
-B02008 Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs The unresponsiveness has to do with the fact that arch_local_irq_restore() does not guarantees to hard enable interrupts. Could you elaborate? If the saved IRQ state was enabled, why wouldn't

RE: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Caraman Mihai Claudiu-B02008
-Original Message- From: Wood Scott-B07421 Sent: Friday, May 03, 2013 11:15 PM To: Caraman Mihai Claudiu-B02008 Cc: Wood Scott-B07421; kvm-ppc@vger.kernel.org; k...@vger.kernel.org; linuxppc-...@lists.ozlabs.org Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Benjamin Herrenschmidt
On Fri, 2013-05-03 at 18:24 +0200, Alexander Graf wrote: There is no reason to exit guest with soft_enabled == 1, a local_irq_enable() call will do this for us so get rid of kvmppc_layz_ee() calls. With this fix we eliminate irqs_disabled() warnings and some guest and host hangs revealed

Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Scott Wood
Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs The unresponsiveness has to do with the fact that arch_local_irq_restore() does not guarantees to hard enable interrupts. Could you elaborate? If the saved IRQ state was enabled, why wouldn't

RE: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Caraman Mihai Claudiu-B02008
-Original Message- From: Wood Scott-B07421 Sent: Saturday, May 04, 2013 1:07 AM To: Caraman Mihai Claudiu-B02008 Cc: Wood Scott-B07421; kvm-ppc@vger.kernel.org; k...@vger.kernel.org; linuxppc-...@lists.ozlabs.org Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs

2013-05-03 Thread Scott Wood
Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs I replaced the two calls to kvmppc_lazy_ee_enable() with calls to hard_irq_disable(), and it seems to be working fine. Please take a look on 'KVM: PPC64: booke: Hard disable interrupts when entering guest' RFC thread and see