;
kvm@vger.kernel.org
Subject: Re: [PATCH 21/23] KVM: PPC: Book3S PR: Use mmu_notifier_retry() in
kvmppc_mmu_map_page()
On Wed, Aug 07, 2013 at 05:17:29AM +, Bhushan Bharat-R65777 wrote:
Pauls, I am trying to understand the flow; does retry mean that we do not
create the mapping
...@vger.kernel.org
Subject: Re: [PATCH 21/23] KVM: PPC: Book3S PR: Use mmu_notifier_retry() in
kvmppc_mmu_map_page()
On Wed, Aug 07, 2013 at 05:17:29AM +, Bhushan Bharat-R65777 wrote:
Pauls, I am trying to understand the flow; does retry mean that we do not
create the mapping
On Wed, Aug 07, 2013 at 05:17:29AM +, Bhushan Bharat-R65777 wrote:
Pauls, I am trying to understand the flow; does retry mean that we do not
create the mapping and return to guest, which will fault again and then we
will retry?
Yes, and you do put_page or kvm_release_pfn_clean for any
-Original Message-
From: Paul Mackerras [mailto:pau...@samba.org]
Sent: Wednesday, August 07, 2013 1:58 PM
To: Bhushan Bharat-R65777
Cc: Alexander Graf; Benjamin Herrenschmidt; kvm-...@vger.kernel.org;
kvm@vger.kernel.org
Subject: Re: [PATCH 21/23] KVM: PPC: Book3S PR: Use
On Wed, Aug 07, 2013 at 05:17:29AM +, Bhushan Bharat-R65777 wrote:
Pauls, I am trying to understand the flow; does retry mean that we do not
create the mapping and return to guest, which will fault again and then we
will retry?
Yes, and you do put_page or kvm_release_pfn_clean for any
-Original Message-
From: Paul Mackerras [mailto:pau...@samba.org]
Sent: Wednesday, August 07, 2013 1:58 PM
To: Bhushan Bharat-R65777
Cc: Alexander Graf; Benjamin Herrenschmidt; kvm-ppc@vger.kernel.org;
k...@vger.kernel.org
Subject: Re: [PATCH 21/23] KVM: PPC: Book3S PR: Use
-Original Message-
From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf
Of
Paul Mackerras
Sent: Tuesday, August 06, 2013 9:58 AM
To: Alexander Graf; Benjamin Herrenschmidt
Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org
Subject: [PATCH 21/23] KVM: PPC:
On Wed, Aug 07, 2013 at 04:13:34AM +, Bhushan Bharat-R65777 wrote:
+ /* used to check for invalidations in progress */
+ mmu_seq = kvm-mmu_notifier_seq;
+ smp_rmb();
Should not the smp_rmb() come before reading kvm-mmu_notifier_seq.
No, it should come after, because it is
-Original Message-
From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf
Of
Paul Mackerras
Sent: Tuesday, August 06, 2013 9:58 AM
To: Alexander Graf; Benjamin Herrenschmidt
Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org
Subject: [PATCH 21/23] KVM: PPC:
-Original Message-
From: Paul Mackerras [mailto:pau...@samba.org]
Sent: Wednesday, August 07, 2013 9:59 AM
To: Bhushan Bharat-R65777
Cc: Alexander Graf; Benjamin Herrenschmidt; kvm-...@vger.kernel.org;
kvm@vger.kernel.org
Subject: Re: [PATCH 21/23] KVM: PPC: Book3S PR: Use
-Original Message-
From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf
Of
Paul Mackerras
Sent: Tuesday, August 06, 2013 9:58 AM
To: Alexander Graf; Benjamin Herrenschmidt
Cc: kvm-ppc@vger.kernel.org; k...@vger.kernel.org
Subject: [PATCH 21/23] KVM: PPC:
On Wed, Aug 07, 2013 at 04:13:34AM +, Bhushan Bharat-R65777 wrote:
+ /* used to check for invalidations in progress */
+ mmu_seq = kvm-mmu_notifier_seq;
+ smp_rmb();
Should not the smp_rmb() come before reading kvm-mmu_notifier_seq.
No, it should come after, because it is
-Original Message-
From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf
Of
Paul Mackerras
Sent: Tuesday, August 06, 2013 9:58 AM
To: Alexander Graf; Benjamin Herrenschmidt
Cc: kvm-ppc@vger.kernel.org; k...@vger.kernel.org
Subject: [PATCH 21/23] KVM: PPC:
-Original Message-
From: Paul Mackerras [mailto:pau...@samba.org]
Sent: Wednesday, August 07, 2013 9:59 AM
To: Bhushan Bharat-R65777
Cc: Alexander Graf; Benjamin Herrenschmidt; kvm-ppc@vger.kernel.org;
k...@vger.kernel.org
Subject: Re: [PATCH 21/23] KVM: PPC: Book3S PR: Use
14 matches
Mail list logo