RE: [RFC][PATCH v4 05/18] Add a function to indicate if device use external buffer.

2010-04-28 Thread Xin, Xiaohui
+static int dev_is_mpassthru(struct net_device *dev) bool return value should be better here. -- Regards， Changli Gao(xiao...@gmail.com) Thanks, would fix that. Thanks Xiaohui -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [RFC][PATCH v4 05/18] Add a function to indicate if device use external buffer.

2010-04-25 Thread Changli Gao
On Sun, Apr 25, 2010 at 5:19 PM, xiaohui@intel.com wrote: +static int dev_is_mpassthru(struct net_device *dev) +{ +       if (dev dev-mp_port) +               return 1; +       return 0; +} + Please make it a inline function. And you would write it with less lines of code. return

Re: [RFC][PATCH v4 05/18] Add a function to indicate if device use external buffer.

2010-04-25 Thread Changli Gao
On Sun, Apr 25, 2010 at 5:19 PM, xiaohui@intel.com wrote: +static int dev_is_mpassthru(struct net_device *dev) bool return value should be better here. -- Regards， Changli Gao(xiao...@gmail.com) -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [RFC][PATCH v4 05/18] Add a function to indicate if device use external buffer.

2010-04-25 Thread David Miller
From: Changli Gao xiao...@gmail.com Date: Sun, 25 Apr 2010 17:33:02 +0800 On Sun, Apr 25, 2010 at 5:19 PM, xiaohui@intel.com wrote: +static int dev_is_mpassthru(struct net_device *dev) +{ +       if (dev dev-mp_port) +               return 1; +       return 0; +} + Please make it

Re: [RFC][PATCH v4 05/18] Add a function to indicate if device use external buffer.

2010-04-25 Thread David Miller
From: Changli Gao xiao...@gmail.com Date: Sun, 25 Apr 2010 17:35:01 +0800 On Sun, Apr 25, 2010 at 5:19 PM, xiaohui@intel.com wrote: +static int dev_is_mpassthru(struct net_device *dev) bool return value should be better here. Right. -- To unsubscribe from this list: send the line