Re: [PATCH] KVM: mark segments accessed on HW task switch

2010-01-25 Thread Avi Kivity
On 01/25/2010 12:01 PM, Gleb Natapov wrote: On HW task switch newly loaded segments should me marked as accessed. @@ -4775,6 +4766,11 @@ int kvm_load_segment_descriptor(struct kvm_vcpu *vcpu, u16 selector, kvm_seg.unusable = 1; kvm_set_segment(vcpu,kvm_seg,

Re: [PATCH] KVM: mark segments accessed on HW task switch

2010-01-25 Thread Gleb Natapov
On Mon, Jan 25, 2010 at 01:08:13PM +0200, Avi Kivity wrote: On 01/25/2010 12:01 PM, Gleb Natapov wrote: On HW task switch newly loaded segments should me marked as accessed. @@ -4775,6 +4766,11 @@ int kvm_load_segment_descriptor(struct kvm_vcpu *vcpu, u16 selector,

Re: [PATCH] KVM: mark segments accessed on HW task switch

2010-01-25 Thread Avi Kivity
On 01/25/2010 01:11 PM, Gleb Natapov wrote: On Mon, Jan 25, 2010 at 01:08:13PM +0200, Avi Kivity wrote: On 01/25/2010 12:01 PM, Gleb Natapov wrote: On HW task switch newly loaded segments should me marked as accessed. @@ -4775,6 +4766,11 @@ int kvm_load_segment_descriptor(struct

Re: [PATCH] KVM: mark segments accessed on HW task switch

2010-01-25 Thread Gleb Natapov
On Mon, Jan 25, 2010 at 01:12:36PM +0200, Avi Kivity wrote: On 01/25/2010 01:11 PM, Gleb Natapov wrote: On Mon, Jan 25, 2010 at 01:08:13PM +0200, Avi Kivity wrote: On 01/25/2010 12:01 PM, Gleb Natapov wrote: On HW task switch newly loaded segments should me marked as accessed. @@ -4775,6

Re: [PATCH] KVM: mark segments accessed on HW task switch

2010-01-25 Thread Avi Kivity
On 01/25/2010 02:24 PM, Gleb Natapov wrote: On Mon, Jan 25, 2010 at 01:12:36PM +0200, Avi Kivity wrote: On 01/25/2010 01:11 PM, Gleb Natapov wrote: On Mon, Jan 25, 2010 at 01:08:13PM +0200, Avi Kivity wrote: On 01/25/2010 12:01 PM, Gleb Natapov wrote: On HW task

Re: [PATCH] KVM: mark segments accessed on HW task switch

2010-01-25 Thread Gleb Natapov
On Mon, Jan 25, 2010 at 02:53:09PM +0200, Avi Kivity wrote: On 01/25/2010 02:24 PM, Gleb Natapov wrote: On Mon, Jan 25, 2010 at 01:12:36PM +0200, Avi Kivity wrote: On 01/25/2010 01:11 PM, Gleb Natapov wrote: On Mon, Jan 25, 2010 at 01:08:13PM +0200, Avi Kivity wrote: On 01/25/2010 12:01 PM,

Re: [PATCH] KVM: mark segments accessed on HW task switch

2010-01-25 Thread Avi Kivity
On 01/25/2010 04:22 PM, Gleb Natapov wrote: Things like 'return kvm_write_guest_virt()' do handle it. That what save_guest_segment_descriptor() calls, but error is not propagated to userspace anywhere in the task switch code. Lets apply this patch and I'll send follow up with fixes for

Re: [PATCH] KVM: mark segments accessed on HW task switch

2010-01-25 Thread Marcelo Tosatti
On Mon, Jan 25, 2010 at 12:01:04PM +0200, Gleb Natapov wrote: On HW task switch newly loaded segments should me marked as accessed. Reported-by: Lorenzo Martignoni martig...@gmail.com Signed-off-by: Gleb Natapov g...@redhat.com Applied, thanks. -- To unsubscribe from this list: send the