Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-26 Thread Jes Sorensen
On 01/26/10 07:46, Gleb Natapov wrote: On Mon, Jan 25, 2010 at 06:13:35PM +0100, Jes Sorensen wrote: I am fine with having QEMU build the e820 tables completely if there is a consensus to take that path. QEMU can't build the e820 map completely. There are things it doesn't know. Like how much

Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Alexander Graf
On 25.01.2010, at 17:52, Jes Sorensen wrote: Hi, This is the QEMU patch for providing the e820-reserve space through qemu-cfg. Howdy. Congratulations to the new mail address - looks neat ;-). Two comments: 1) I don't see how passing a single region is any help. I'd rather like to see a

Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Alexander Graf
Am 25.01.2010 um 18:13 schrieb Jes Sorensen jes.soren...@redhat.com: On 01/25/10 17:58, Alexander Graf wrote: Howdy. Congratulations to the new mail address - looks neat ;-). :-) Two comments: 1) I don't see how passing a single region is any help. I'd rather like to see a device tree

Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Jes Sorensen
On 01/25/10 18:28, Alexander Graf wrote: That way we'd get 2 entries and the chance to enhance them later on. In fact, it might even make sense to pass the whole table in such a form. That way qemu generates all of the e820 tables and we can declare whatever we want. Just add a type field in the

Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Alexander Graf
On 25.01.2010, at 18:46, Jes Sorensen wrote: On 01/25/10 18:28, Alexander Graf wrote: That way we'd get 2 entries and the chance to enhance them later on. In fact, it might even make sense to pass the whole table in such a form. That way qemu generates all of the e820 tables and we can

Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Anthony Liguori
On 01/25/2010 02:04 PM, Alexander Graf wrote: On 25.01.2010, at 18:46, Jes Sorensen wrote: On 01/25/10 18:28, Alexander Graf wrote: That way we'd get 2 entries and the chance to enhance them later on. In fact, it might even make sense to pass the whole table in such a form. That way

Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Jes Sorensen
On 01/25/10 21:14, Anthony Liguori wrote: On 01/25/2010 02:04 PM, Alexander Graf wrote: Yes, sounds good. Should be fairly extensible then. What about memory holes? Do we need to take care of them? It would be nice for QEMU to be able to add additional e820 regions that don't necessarily fit

Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Alexander Graf
On 25.01.2010, at 22:05, Jes Sorensen wrote: On 01/25/10 21:14, Anthony Liguori wrote: On 01/25/2010 02:04 PM, Alexander Graf wrote: Yes, sounds good. Should be fairly extensible then. What about memory holes? Do we need to take care of them? It would be nice for QEMU to be able to add

Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Jes Sorensen
On 01/25/10 22:08, Alexander Graf wrote: On 25.01.2010, at 22:05, Jes Sorensen wrote: Only problem is that we don't really have a way to pass back info saying 'you messed up trying to pinch an area that the BIOS wants for itself'. Eh - the BIOS shouldn't even try to use regions that are

Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Gleb Natapov
On Mon, Jan 25, 2010 at 06:13:35PM +0100, Jes Sorensen wrote: On 01/25/10 17:58, Alexander Graf wrote: Howdy. Congratulations to the new mail address - looks neat ;-). :-) Two comments: 1) I don't see how passing a single region is any help. I'd rather like to see a device tree like