Re: [PATCH] disable interrupt shadow state for emulated instruction

2009-04-09 Thread Avi Kivity
H. Peter Anvin wrote: How does this logic work when the instruction emulated is an STI or MOV SS instruction? In particular, when does GUEST_INTERRUPTIBILITY_INFO sets set to reflect the *blocking* operation? The processor sets it when emulating an sti or mov ss instruction. We ought to

Re: [PATCH] disable interrupt shadow state for emulated instruction

2009-04-09 Thread Avi Kivity
Glauber Costa wrote: How does this logic work when the instruction emulated is an STI or MOV SS instruction? In particular, when does GUEST_INTERRUPTIBILITY_INFO sets set to reflect the *blocking* operation? mov ss is a non-issue, since it is executed natively. Except in big real

Re: [PATCH] disable interrupt shadow state for emulated instruction

2009-04-08 Thread H. Peter Anvin
Glauber Costa wrote: we currently unblock shadow interrupt state when we skip an instruction, but failing to do so when we actually emulate one. This blocks interrupts in key instruction blocks, in particular sti; hlt; sequences Without this patch, I cannot boot gpxe option roms at vmx

Re: [PATCH] disable interrupt shadow state for emulated instruction

2009-04-08 Thread Glauber Costa
On Wed, Apr 08, 2009 at 11:16:05AM -0700, H. Peter Anvin wrote: Glauber Costa wrote: we currently unblock shadow interrupt state when we skip an instruction, but failing to do so when we actually emulate one. This blocks interrupts in key instruction blocks, in particular sti; hlt; sequences

Re: [PATCH] disable interrupt shadow state for emulated instruction

2009-04-08 Thread H. Peter Anvin
Glauber Costa wrote: mov ss is a non-issue, since it is executed natively. In real mode? -hpa -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] disable interrupt shadow state for emulated instruction

2009-04-08 Thread Glauber Costa
On Wed, Apr 08, 2009 at 11:31:54AM -0700, H. Peter Anvin wrote: Glauber Costa wrote: mov ss is a non-issue, since it is executed natively. In real mode? it seems so, to me. But I can be wrong. If I am, then I'd propose the same path I proposed for sti for this. -- To unsubscribe from this

Re: [PATCH] disable interrupt shadow state for emulated instruction

2009-04-08 Thread Gleb Natapov
On Wed, Apr 08, 2009 at 01:57:32PM -0400, Glauber Costa wrote: we currently unblock shadow interrupt state when we skip an instruction, but failing to do so when we actually emulate one. This blocks interrupts in key instruction blocks, in particular sti; hlt; sequences Without this patch, I

Re: [PATCH] disable interrupt shadow state for emulated instruction

2009-04-08 Thread Gleb Natapov
On Wed, Apr 08, 2009 at 03:43:06PM -0300, Glauber Costa wrote: On Wed, Apr 08, 2009 at 11:31:54AM -0700, H. Peter Anvin wrote: Glauber Costa wrote: mov ss is a non-issue, since it is executed natively. In real mode? it seems so, to me. But I can be wrong. If I am, then I'd propose the