Re: [PATCH] fix memory leak in virtio_net

On Tue, 11 Aug 2009 09:22:58 pm Avi Kivity wrote: (copying Rusty, the virtio maintainer) On 08/10/2009 11:05 PM, Shirley Ma wrote: Whild reading virtio code, I found some memory leak in removing virtio_net. In virtnet_remove, only skb has been freed not the pages in skb frags. Here

Re: [PATCH] fix memory leak in virtio_net

This is false report. I checked kfree_skb(), it does free all pages in the fraglist in skb_release_data() later. Thanks Shirley On Mon, 2009-08-10 at 13:05 -0700, Shirley Ma wrote: Whild reading virtio code, I found some memory leak in removing virtio_net. In virtnet_remove, only skb has

Re: [PATCH] fix memory leak in virtio_net

(copying Rusty, the virtio maintainer) On 08/10/2009 11:05 PM, Shirley Ma wrote: Whild reading virtio code, I found some memory leak in removing virtio_net. In virtnet_remove, only skb has been freed not the pages in skb frags. Here is the patch to fix this, please review it. There were

Re: [PATCH] fix memory leak in virtio_net

Hello Avi, I do see memory leak after removing virtio_net module. There is 72KB per removal along with free already free IRQ. Maybe the memleak from virtio_pci, seems some lock is missing when accessing the irq list? Trying to free already-free IRQ 26 Modules linked in: virtio_net(-) sunrpc ipv6