Re: kvm: RCU warning in async pf

2012-04-16 Thread Gleb Natapov
On Sat, Apr 14, 2012 at 11:44:53AM +0200, Peter Zijlstra wrote: On Wed, 2012-04-04 at 15:30 +0300, Gleb Natapov wrote: @@ -253,7 +254,10 @@ do_async_page_fault(struct pt_regs *regs, unsigned long error_code) kvm_async_pf_task_wait((u32)read_cr2()); break;

Re: kvm: RCU warning in async pf

2012-04-16 Thread Gleb Natapov
On Mon, Apr 16, 2012 at 01:28:55PM +0300, Gleb Natapov wrote: On Sat, Apr 14, 2012 at 11:44:53AM +0200, Peter Zijlstra wrote: On Wed, 2012-04-04 at 15:30 +0300, Gleb Natapov wrote: @@ -253,7 +254,10 @@ do_async_page_fault(struct pt_regs *regs, unsigned long error_code)

Re: kvm: RCU warning in async pf

2012-04-16 Thread Peter Zijlstra
On Mon, 2012-04-16 at 15:58 +0300, Gleb Natapov wrote: - rcu_irq_enter(); + irq_enter(); exit_idle(); Do we really need the exit_idle()? I can't remember other interrupt handlers doing that. -- To unsubscribe from this list: send the line

Re: kvm: RCU warning in async pf

2012-04-16 Thread Gleb Natapov
On Mon, Apr 16, 2012 at 03:05:48PM +0200, Peter Zijlstra wrote: On Mon, 2012-04-16 at 15:58 +0300, Gleb Natapov wrote: - rcu_irq_enter(); + irq_enter(); exit_idle(); Do we really need the exit_idle()? I can't remember other interrupt handlers

Re: kvm: RCU warning in async pf

2012-04-16 Thread Peter Zijlstra
On Mon, 2012-04-16 at 16:08 +0300, Gleb Natapov wrote: On Mon, Apr 16, 2012 at 03:05:48PM +0200, Peter Zijlstra wrote: On Mon, 2012-04-16 at 15:58 +0300, Gleb Natapov wrote: - rcu_irq_enter(); + irq_enter(); exit_idle(); Do we really

Re: kvm: RCU warning in async pf

2012-04-16 Thread Peter Zijlstra
On Mon, 2012-04-16 at 15:18 +0200, Peter Zijlstra wrote: On Mon, 2012-04-16 at 16:08 +0300, Gleb Natapov wrote: On Mon, Apr 16, 2012 at 03:05:48PM +0200, Peter Zijlstra wrote: On Mon, 2012-04-16 at 15:58 +0300, Gleb Natapov wrote: - rcu_irq_enter(); +

Re: kvm: RCU warning in async pf

2012-04-16 Thread Gleb Natapov
On Mon, Apr 16, 2012 at 03:27:20PM +0200, Peter Zijlstra wrote: On Mon, 2012-04-16 at 15:18 +0200, Peter Zijlstra wrote: On Mon, 2012-04-16 at 16:08 +0300, Gleb Natapov wrote: On Mon, Apr 16, 2012 at 03:05:48PM +0200, Peter Zijlstra wrote: On Mon, 2012-04-16 at 15:58 +0300, Gleb Natapov

Re: kvm: RCU warning in async pf

2012-04-16 Thread Peter Zijlstra
On Mon, 2012-04-16 at 17:17 +0300, Gleb Natapov wrote: Should I resend the patch with removal of exit_idle() call or it will be removed by a patch that removes exit_idle() completely later? I think we can do the latter, once we decided what to do with that stuff we can clean it up/remove it

Re: kvm: RCU warning in async pf

2012-04-14 Thread Peter Zijlstra
On Wed, 2012-04-04 at 15:30 +0300, Gleb Natapov wrote: @@ -253,7 +254,10 @@ do_async_page_fault(struct pt_regs *regs, unsigned long error_code) kvm_async_pf_task_wait((u32)read_cr2()); break; case KVM_PV_REASON_PAGE_READY: + rcu_irq_enter();

Re: kvm: RCU warning in async pf

2012-04-04 Thread Gleb Natapov
On Tue, Apr 03, 2012 at 01:52:26PM +0300, Gleb Natapov wrote: On Mon, Apr 02, 2012 at 08:54:32PM -0400, Sasha Levin wrote: Hi all, I got the spew at the bottom of the mail in a KVM guest using the KVM tools and running trinity. I'm not quite sure how default_idle managed to trigger

Re: kvm: RCU warning in async pf

2012-04-04 Thread Paul E. McKenney
On Wed, Apr 04, 2012 at 03:30:33PM +0300, Gleb Natapov wrote: On Tue, Apr 03, 2012 at 01:52:26PM +0300, Gleb Natapov wrote: On Mon, Apr 02, 2012 at 08:54:32PM -0400, Sasha Levin wrote: Hi all, I got the spew at the bottom of the mail in a KVM guest using the KVM tools and running

Re: kvm: RCU warning in async pf

2012-04-04 Thread Gleb Natapov
On Wed, Apr 04, 2012 at 07:04:16AM -0700, Paul E. McKenney wrote: On Wed, Apr 04, 2012 at 03:30:33PM +0300, Gleb Natapov wrote: On Tue, Apr 03, 2012 at 01:52:26PM +0300, Gleb Natapov wrote: On Mon, Apr 02, 2012 at 08:54:32PM -0400, Sasha Levin wrote: Hi all, I got the spew at

Re: kvm: RCU warning in async pf

2012-04-04 Thread Sasha Levin
On Wed, Apr 4, 2012 at 2:30 PM, Gleb Natapov g...@redhat.com wrote: On Tue, Apr 03, 2012 at 01:52:26PM +0300, Gleb Natapov wrote: On Mon, Apr 02, 2012 at 08:54:32PM -0400, Sasha Levin wrote: Hi all, I got the spew at the bottom of the mail in a KVM guest using the KVM tools and running

Re: kvm: RCU warning in async pf

2012-04-03 Thread Gleb Natapov
On Mon, Apr 02, 2012 at 08:54:32PM -0400, Sasha Levin wrote: Hi all, I got the spew at the bottom of the mail in a KVM guest using the KVM tools and running trinity. I'm not quite sure how default_idle managed to trigger a pagefault, so that part looks odd to me. This is not regular

Re: kvm: RCU warning in async pf

2012-04-03 Thread Paul E. McKenney
On Mon, Apr 02, 2012 at 08:54:32PM -0400, Sasha Levin wrote: Hi all, I got the spew at the bottom of the mail in a KVM guest using the KVM tools and running trinity. I'm not quite sure how default_idle managed to trigger a pagefault, so that part looks odd to me. Wrapping the offending

kvm: RCU warning in async pf

2012-04-02 Thread Sasha Levin
Hi all, I got the spew at the bottom of the mail in a KVM guest using the KVM tools and running trinity. I'm not quite sure how default_idle managed to trigger a pagefault, so that part looks odd to me. [12140.220507] === [12140.220507] [ INFO: suspicious RCU