Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change

2009-03-06 Thread Filip Navara
On Wed, Feb 11, 2009 at 5:48 PM, Jamie Lokier wrote: > Kevin Wolf wrote: >> Besides reviewing the code over and over again, I think the only real >> chance is that you can get a non-productive copy of your image and add >> some debug code so that we can see at least which code path is causing >> p

Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change

2009-02-16 Thread Jamie Lokier
Kevin Wolf wrote: > >> By the way and completely off-topic: Have you already tried to use the > >> VHD patches? I would really like to know if they fix your problems. > > > > Are those patches in kvm-83? I still have the image that was causing > > problems way back, and I'm converting it to raw n

Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change

2009-02-16 Thread Kevin Wolf
Jamie Lokier schrieb: > Kevin Wolf wrote: >> Besides reviewing the code over and over again, I think the only real >> chance is that you can get a non-productive copy of your image and add >> some debug code so that we can see at least which code path is causing >> problems. > > I have a copy of m

Re: qcow2 corruption observed, fixed by reverting old change

2009-02-15 Thread Marc Bevand
On Sun, Feb 15, 2009 at 3:46 AM, Marc Bevand wrote: > Other factors you might consider when trying to reproduce: [...] And the probability of that bug occuring seems less than 1% (I only witnessed 6 or 7 occurences out of about a thousand shutdown events). Also, contrary to what I said I am *not

Re: qcow2 corruption observed, fixed by reverting old change

2009-02-15 Thread Marc Bevand
On Sun, Feb 15, 2009 at 2:57 AM, Gleb Natapov wrote: > > I am not able to reproduce this. After more then hundred boot linux; generate > disk io; quit loops all I've got is an image with 7 leaked blocks and > couple of filesystem corruptions that were fixed by fsck. The type of activity occuring

Re: qcow2 corruption observed, fixed by reverting old change

2009-02-15 Thread Gleb Natapov
> > I tested kvm-81 and kvm-83 as well (can't test kvm-80 or older because of > > the > > qcow2 performance regression caused by the default writethrough caching > > policy) > > but it randomly triggers an even worse bug: the moment I shut down a guest > > by > > typing "quit" in the monitor, it

Re: [Qemu-devel] Re: qcow2 corruption observed, fixed by reverting old change

2009-02-14 Thread Marc Bevand
On Sat, Feb 14, 2009 at 2:28 PM, Dor Laor wrote: > > Both qcow2 and vmdk have the ability to keep 'external' snapshots. I know but they don't implement one feature I cited: clones, or "writable snapshots", which I would like implemented with support for deduplication. Base images / backing files

Re: [Qemu-devel] Re: qcow2 corruption observed, fixed by reverting old change

2009-02-14 Thread Jamie Lokier
Marc Bevand wrote: > On Fri, Feb 13, 2009 at 8:23 AM, Jamie Lokier wrote: > > > > Marc.. this is quite a serious bug you've reported. Is there a > > reason you didn't report it earlier? > > Because I only started hitting that bug a couple weeks ago after > having upgraded to a buggy kvm version

Re: [Qemu-devel] Re: qcow2 corruption observed, fixed by reverting old change

2009-02-14 Thread Jamie Lokier
Dor Laor wrote: > Both qcow2 and vmdk have the ability to keep 'external' snapshots. I didn't see any mention of this in QEMU's documentation. One of the most annoying features of qcow2 is "savevm" storing all VM snapshots in the same qcow2 file. Is this not true? > In addition to what you wrot

Re: [Qemu-devel] Re: qcow2 corruption observed, fixed by reverting old change

2009-02-14 Thread Dor Laor
Marc Bevand wrote: On Fri, Feb 13, 2009 at 8:23 AM, Jamie Lokier wrote: Marc.. this is quite a serious bug you've reported. Is there a reason you didn't report it earlier? Because I only started hitting that bug a couple weeks ago after having upgraded to a buggy kvm version. I

Re: [Qemu-devel] Re: qcow2 corruption observed, fixed by reverting old change

2009-02-13 Thread Marc Bevand
On Fri, Feb 13, 2009 at 8:23 AM, Jamie Lokier wrote: > > Marc.. this is quite a serious bug you've reported. Is there a > reason you didn't report it earlier? Because I only started hitting that bug a couple weeks ago after having upgraded to a buggy kvm version. > Is there a way to restructur

Re: [Qemu-devel] Re: qcow2 corruption observed, fixed by reverting old change

2009-02-13 Thread Chris Wright
* Jamie Lokier (ja...@shareable.org) wrote: > no reason to believe kvm-83 is "stable", but there's no reason to > believe any other version of KVM is especially stable either - there's > no stabilising bug fix only branch that I'm aware of. There's ad-hoc one w/out formal releases. But...never be

Re: [Qemu-devel] Re: qcow2 corruption observed, fixed by reverting old change

2009-02-13 Thread Jamie Lokier
Marc Bevand schrieb: > I tested kvm-81 and kvm-83 as well (can't test kvm-80 or older > because of the qcow2 performance regression caused by the default > writethrough caching policy) but it randomly triggers an even worse > bug: the moment I shut down a guest by typing "quit" in the monitor, > it

Re: qcow2 corruption observed, fixed by reverting old change

2009-02-13 Thread Kevin Wolf
Hi Marc, You should not take qemu-devel out of the CC list. This is where the bugs need to be fixed, they aren't KVM specific. I'm quoting your complete mail to forward it to where it belongs. Marc Bevand schrieb: > Jamie Lokier shareable.org> writes: >> As you see from the subject, I'm getting

Re: qcow2 corruption observed, fixed by reverting old change

2009-02-12 Thread Marc Bevand
Jamie Lokier shareable.org> writes: > > As you see from the subject, I'm getting qcow2 corruption. > > I have a Windows 2000 guest which boots and runs fine in kvm-72, fails > with a blue-screen indicating file corruption errors in kvm-73 through > to kvm-83 (the latest), and succeeds if I repla

Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change

2009-02-12 Thread Johannes Schindelin
Hi, On Wed, 11 Feb 2009, Chris Wright wrote: > * Kevin Wolf (kw...@suse.de) wrote: > > I would suspect that simply having a 64 bit host isn't enough to trigger > > the problem. These patches were in for half a year now without anyone > > noticing such failure. > > BTW, we've seen similar corrupt

Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change

2009-02-11 Thread Chris Wright
* Kevin Wolf (kw...@suse.de) wrote: > I would suspect that simply having a 64 bit host isn't enough to trigger > the problem. These patches were in for half a year now without anyone > noticing such failure. BTW, we've seen similar corruption, but not narrowed it down successfully as it's been qui

Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change

2009-02-11 Thread Jamie Lokier
Kevin Wolf wrote: > Besides reviewing the code over and over again, I think the only real > chance is that you can get a non-productive copy of your image and add > some debug code so that we can see at least which code path is causing > problems. I have a copy of my image to reproduce the bug, so

Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change

2009-02-11 Thread Kevin Wolf
Jamie Lokier schrieb: > Kevin Wolf wrote: >> Jamie Lokier schrieb: >>> Although there are many ways to make Windows blue screen in KVM, in >>> this case I've narrowed it down to the difference in >>> qemu/block-qcow2.c between kvm-72 and kvm-73 (not -83). >> This must be one of SVN revisions 5003 t

Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change

2009-02-11 Thread Jamie Lokier
Kevin Wolf wrote: > Jamie Lokier schrieb: > > Although there are many ways to make Windows blue screen in KVM, in > > this case I've narrowed it down to the difference in > > qemu/block-qcow2.c between kvm-72 and kvm-73 (not -83). > > This must be one of SVN revisions 5003 to 5008 in upstream qemu

Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change

2009-02-11 Thread Jamie Lokier
Kevin Wolf wrote: > Jamie Lokier schrieb: > > Although there are many ways to make Windows blue screen in KVM, in > > this case I've narrowed it down to the difference in > > qemu/block-qcow2.c between kvm-72 and kvm-73 (not -83). > > This must be one of SVN revisions 5003 to 5008 in upstream qemu

Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change

2009-02-11 Thread Kevin Wolf
Jamie Lokier schrieb: > Although there are many ways to make Windows blue screen in KVM, in > this case I've narrowed it down to the difference in > qemu/block-qcow2.c between kvm-72 and kvm-73 (not -83). This must be one of SVN revisions 5003 to 5008 in upstream qemu. Can you narrow it down to on

qcow2 corruption observed, fixed by reverting old change

2009-02-10 Thread Jamie Lokier
Hi, As you see from the subject, I'm getting qcow2 corruption. I have a Windows 2000 guest which boots and runs fine in kvm-72, fails with a blue-screen indicating file corruption errors in kvm-73 through to kvm-83 (the latest), and succeeds if I replace block-qcow2.c with the version from kvm-72