Re: qemu-kvm: enable get/set vcpu events on reset and migration

2010-01-28 Thread Jan Kiszka
Gleb Natapov wrote: > On Tue, Jan 26, 2010 at 10:26:22PM -0200, Marcelo Tosatti wrote: >> @@ -374,6 +375,7 @@ static int cpu_post_load(void *opaque, int version_id) >> >> kvm_load_tsc(env); >> kvm_load_mpstate(env); >> +kvm_put_vcpu_events(env); >> } > It is confusi

Re: qemu-kvm: enable get/set vcpu events on reset and migration

2010-01-28 Thread Gleb Natapov
On Tue, Jan 26, 2010 at 10:26:22PM -0200, Marcelo Tosatti wrote: > @@ -374,6 +375,7 @@ static int cpu_post_load(void *opaque, int version_id) > > kvm_load_tsc(env); > kvm_load_mpstate(env); > +kvm_put_vcpu_events(env); > } It is confusing to call functions load/save

Re: qemu-kvm: enable get/set vcpu events on reset and migration

2010-01-28 Thread Jan Kiszka
Marcelo Tosatti wrote: >> The last two hunks will cause the same !CONFIG_KVM breakages qemu-kvm's >> mpstate used to as well. You may either fix it up temporarily or wait >> for my refactoring that is now scheduled with highest priority (should >> be ready today or tomorrow). > > It needs to go in

qemu-kvm: enable get/set vcpu events on reset and migration

2010-01-27 Thread Marcelo Tosatti
> The last two hunks will cause the same !CONFIG_KVM breakages qemu-kvm's > mpstate used to as well. You may either fix it up temporarily or wait > for my refactoring that is now scheduled with highest priority (should > be ready today or tomorrow). It needs to go in 0.12-stable, so we'll have to

Re: qemu-kvm: enable get/set vcpu events on reset and migration

2010-01-27 Thread Jan Kiszka
Marcelo Tosatti wrote: > qemu-kvm should reset and save/restore vcpu events. > > Signed-off-by: Marcelo Tosatti > > diff --git a/kvm.h b/kvm.h > index e2a945b..9fa4e25 100644 > --- a/kvm.h > +++ b/kvm.h > @@ -52,6 +52,9 @@ int kvm_set_migration_log(int enable); > int kvm_has_sync_mmu(void); >

qemu-kvm: enable get/set vcpu events on reset and migration

2010-01-26 Thread Marcelo Tosatti
qemu-kvm should reset and save/restore vcpu events. Signed-off-by: Marcelo Tosatti diff --git a/kvm.h b/kvm.h index e2a945b..9fa4e25 100644 --- a/kvm.h +++ b/kvm.h @@ -52,6 +52,9 @@ int kvm_set_migration_log(int enable); int kvm_has_sync_mmu(void); #endif /* KVM_UPSTREAM */ int kvm_has_vcpu_