Re: virtio-net mq vq initialization

2013-04-22 Thread Sasha Levin
On 04/15/2013 01:58 AM, Jason Wang wrote: >> Initializing them only when they're actually needed will do the trick here. > I don't see so much memory allocation with qemu, the main problem I > guess here is kvmtool does not support mergeable rx buffers ( does it? > ). So guest must allocate 64K per

Re: virtio-net mq vq initialization

2013-04-14 Thread Jason Wang
On 04/14/2013 11:16 PM, Sasha Levin wrote: > On 04/14/2013 06:01 AM, Michael S. Tsirkin wrote: >> On Sat, Apr 13, 2013 at 05:23:41PM -0400, Sasha Levin wrote: >>> On 04/12/2013 07:36 AM, Rusty Russell wrote: Sasha Levin writes: > On 04/11/2013 12:36 PM, Will Deacon wrote: >> Hello fol

Re: virtio-net mq vq initialization

2013-04-14 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Sun, Apr 14, 2013 at 11:59:42AM -0400, Sasha Levin wrote: >> On 04/14/2013 11:53 AM, Michael S. Tsirkin wrote: >> >> > >> >> > Initializing them only when they're actually needed will do the trick >> >> > here. >> > Not initializing, adding the buffers. In the c

Re: virtio-net mq vq initialization

2013-04-14 Thread Michael S. Tsirkin
On Sun, Apr 14, 2013 at 11:59:42AM -0400, Sasha Levin wrote: > On 04/14/2013 11:53 AM, Michael S. Tsirkin wrote: > >> > > >> > Initializing them only when they're actually needed will do the trick > >> > here. > > Not initializing, adding the buffers. In the current spec, initialization > > is al

Re: virtio-net mq vq initialization

2013-04-14 Thread Sasha Levin
On 04/14/2013 11:53 AM, Michael S. Tsirkin wrote: >> > >> > Initializing them only when they're actually needed will do the trick here. > Not initializing, adding the buffers. In the current spec, initialization > is always done before DRIVER_OK. Yeah, that's better, but we're going to need a spe

Re: virtio-net mq vq initialization

2013-04-14 Thread Michael S. Tsirkin
On Sun, Apr 14, 2013 at 11:16:46AM -0400, Sasha Levin wrote: > On 04/14/2013 06:01 AM, Michael S. Tsirkin wrote: > > On Sat, Apr 13, 2013 at 05:23:41PM -0400, Sasha Levin wrote: > >> On 04/12/2013 07:36 AM, Rusty Russell wrote: > >>> Sasha Levin writes: > On 04/11/2013 12:36 PM, Will Deacon w

Re: virtio-net mq vq initialization

2013-04-14 Thread Sasha Levin
On 04/14/2013 06:01 AM, Michael S. Tsirkin wrote: > On Sat, Apr 13, 2013 at 05:23:41PM -0400, Sasha Levin wrote: >> On 04/12/2013 07:36 AM, Rusty Russell wrote: >>> Sasha Levin writes: On 04/11/2013 12:36 PM, Will Deacon wrote: > Hello folks, > > Here's the latest round of ARM fix

Re: virtio-net mq vq initialization (was: [PATCH 0/5] Usual batch of random ARM fixes for kvmtool)

2013-04-14 Thread Michael S. Tsirkin
On Fri, Apr 12, 2013 at 01:41:58PM +0100, Will Deacon wrote: > Hi Rusty, > > On Fri, Apr 12, 2013 at 12:36:00PM +0100, Rusty Russell wrote: > > I'm confused. kvmtool is using too much memory, or the guest? If > > kvmtool, the Device Initialization section above applies to the driver, > > not the

Re: virtio-net mq vq initialization

2013-04-14 Thread Michael S. Tsirkin
On Sat, Apr 13, 2013 at 05:23:41PM -0400, Sasha Levin wrote: > On 04/12/2013 07:36 AM, Rusty Russell wrote: > > Sasha Levin writes: > >> On 04/11/2013 12:36 PM, Will Deacon wrote: > >>> Hello folks, > >>> > >>> Here's the latest round of ARM fixes and updates for kvmtool. Most of > >>> this is con

Re: virtio-net mq vq initialization

2013-04-13 Thread Sasha Levin
On 04/12/2013 07:36 AM, Rusty Russell wrote: > Sasha Levin writes: >> On 04/11/2013 12:36 PM, Will Deacon wrote: >>> Hello folks, >>> >>> Here's the latest round of ARM fixes and updates for kvmtool. Most of >>> this is confined to the arm/ subdirectory, with the exception of a fix >>> to the virt

Re: virtio-net mq vq initialization (was: [PATCH 0/5] Usual batch of random ARM fixes for kvmtool)

2013-04-12 Thread Will Deacon
Hi Rusty, On Fri, Apr 12, 2013 at 12:36:00PM +0100, Rusty Russell wrote: > I'm confused. kvmtool is using too much memory, or the guest? If > kvmtool, the Device Initialization section above applies to the driver, > not the device. If the guest, well, the language says "UP TO N+1". You > want

Re: virtio-net mq vq initialization (was: [PATCH 0/5] Usual batch of random ARM fixes for kvmtool)

2013-04-12 Thread Rusty Russell
Sasha Levin writes: > On 04/11/2013 12:36 PM, Will Deacon wrote: >> Hello folks, >> >> Here's the latest round of ARM fixes and updates for kvmtool. Most of >> this is confined to the arm/ subdirectory, with the exception of a fix >> to the virtio-mmio vq definitions due to the multi-queue work f

virtio-net mq vq initialization (was: [PATCH 0/5] Usual batch of random ARM fixes for kvmtool)

2013-04-11 Thread Sasha Levin
On 04/11/2013 12:36 PM, Will Deacon wrote: > Hello folks, > > Here's the latest round of ARM fixes and updates for kvmtool. Most of > this is confined to the arm/ subdirectory, with the exception of a fix > to the virtio-mmio vq definitions due to the multi-queue work from > Sasha. I'm not terribl