Biweekly KVM Test report, kernel 78621... qemu f3600...

2009-08-31 Thread Xu, Jiajun
Hi All, This Weekly KVM Testing Report against lastest kvm.git 786212855ddce3df06e9c28ab228648f66e39409 and qemu-kvm.git f3600c589a9ee5ea4c0fec74ed4e06a15b461d52. There is 1 new bug found with SR-IOV device this week. Migration works well now on both 64-bit and 32-bit host. One New issue:

Re: R/W HG memory mappings with kvm?

2009-08-31 Thread Avi Kivity
On 08/31/2009 01:33 AM, Stephen Donnelly wrote: We can't duplicate mm/ in kvm. However, mm/memory.c says: * The way we recognize COWed pages within VM_PFNMAP mappings is through the * rules set up by remap_pfn_range(): the vma will have the VM_PFNMAP bit * set, and the vm_pgoff will

buildbot failure in qemu-kvm on disable_kvm_x86_64_debian_5_0

2009-08-31 Thread qemu-kvm
The Buildbot has detected a new failure of disable_kvm_x86_64_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/disable_kvm_x86_64_debian_5_0/builds/23 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build:

[KVM-AUTOTEST PATCH 0/2] Add KSM test

2009-08-31 Thread Lukáš Doktor
This patch adds KSM test. We faced many difficulties which weren't solvable by regular ways so please take a look and comment. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at

buildbot failure in qemu-kvm on disable_kvm_i386_debian_5_0

2009-08-31 Thread qemu-kvm
The Buildbot has detected a new failure of disable_kvm_i386_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/disable_kvm_i386_debian_5_0/builds/25 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build:

Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test

2009-08-31 Thread Lukáš Doktor
allocator.c is a program, which allocates pages in the memory and allow us to fill or test those pages. It's controlled using sockets. Signed-off-by: Lukáš Doktor ldok...@redhat.com Signed-off-by: Jiří Župka jzu...@redhat.com --- client/tests/kvm/allocator.c | 571

Re: Questions about creating virtual disks with qemu/kvm

2009-08-31 Thread Avi Kivity
On 08/30/2009 10:58 AM, carlopmart wrote: Hi all, I hava some doubts about creating virtual disks under qemu/kvm: a) is it possible to share disks between virtual guests like vmware server, esx and xen does?? for example to setup a virtual cluster with two or more nodes using Red Hat

Re: [KVM-AUTOTEST PATCH 2/2] Add KSM test

2009-08-31 Thread Lukáš Doktor
This is an actual KSM test. It allows to test merging resp splitting the pages in serial, parallel or both. Also you can specify an overcommit ratio for KSM overcommit testing. We were forced to destroy all previous defined vms and to create them inside the test (similar to stress_boot),

Re: RFC: shadow page table reclaim

2009-08-31 Thread Avi Kivity
On 08/28/2009 05:31 AM, Max Laier wrote: Hello, it seems to me that the reclaim mechanism for shadow page table pages is sub- optimal. The arch.active_mmu_pages list that is used for reclaiming does not move up parent shadow page tables when a child is added so when we need a new shadow page

[PATCH] qemu-kvm: fix warning with USE_KVM_DEVICE_ASSIGNMENT disabled

2009-08-31 Thread Daniel Gollub
Spotted by qemu-kvm buildbot: http://buildbot.b1-systems.de/qemu-kvm/builders/default_i386_debian_5_0/builds/33/steps/compile/logs/warnings Sigend-off-by: Daniel Gollub gol...@b1-systems.de --- qemu-kvm-x86.c |2 ++ qemu-kvm.c |4 2 files changed, 6 insertions(+), 0

[PATCH] use __pa_symbol to calculate the address of a C symbol.

2009-08-31 Thread Glauber Costa
The use of __pa() to calculate the address of a C-visible symbol is wrong, and can lead to unpredictable results. See arch/x86/include/asm/page.h for details. It should be replaced with __pa_symbol(), that does the correct math here, by taking relocations into account. Signed-off-by: Glauber

buildbot failure in qemu-kvm on default_x86_64_debian_5_0

2009-08-31 Thread qemu-kvm
The Buildbot has detected a new failure of default_x86_64_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/default_x86_64_debian_5_0/builds/35 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build: b1_qemu_kvm_1

buildbot failure in qemu-kvm on default_i386_debian_5_0

2009-08-31 Thread qemu-kvm
The Buildbot has detected a new failure of default_i386_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/default_i386_debian_5_0/builds/37 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build: b1_qemu_kvm_2 Build

buildbot failure in qemu-kvm on disable_kvm_i386_debian_5_0

2009-08-31 Thread qemu-kvm
The Buildbot has detected a new failure of disable_kvm_i386_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/disable_kvm_i386_debian_5_0/builds/27 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build:

Re: [PATCH] use __pa_symbol to calculate the address of a C symbol.

2009-08-31 Thread Avi Kivity
On 08/31/2009 10:04 AM, Glauber Costa wrote: The use of __pa() to calculate the address of a C-visible symbol is wrong, and can lead to unpredictable results. See arch/x86/include/asm/page.h for details. It should be replaced with __pa_symbol(), that does the correct math here, by taking

Re: buildbot failure in qemu-kvm on default_i386_debian_5_0

2009-08-31 Thread Daniel Gollub
On Monday 31 August 2009 01:21:59 pm qemu-...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure of default_i386_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/default_i386_debian_5_0/bu ilds/37 Looks like the

RE: [PATCHv5 3/3] vhost_net: a kernel-level virtio server

2009-08-31 Thread Xin, Xiaohui
Hi, Michael That's a great job. We are now working on support VMDq on KVM, and since the VMDq hardware presents L2 sorting based on MAC addresses and VLAN tags, our target is to implement a zero copy solution using VMDq. We stared from the virtio-net architecture. What we want to proposal is to

Re: RFC: shadow page table reclaim

2009-08-31 Thread Max Laier
On Monday 31 August 2009 11:55:24 Avi Kivity wrote: On 08/28/2009 05:31 AM, Max Laier wrote: Hello, it seems to me that the reclaim mechanism for shadow page table pages is sub- optimal. The arch.active_mmu_pages list that is used for reclaiming does not move up parent shadow page

Re: [PATCH] x86 emulator: Add missing decoder flags for 'or' instructions

2009-08-31 Thread Avi Kivity
On 08/28/2009 05:41 PM, Mohammed Gamal wrote: Add missing decoder flags for or instructions (0xc-0xd) Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: buildbot failure in qemu-kvm on default_i386_debian_5_0

2009-08-31 Thread Avi Kivity
On 08/31/2009 02:28 PM, Daniel Gollub wrote: On Monday 31 August 2009 01:21:59 pm qemu-...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure of default_i386_debian_5_0 on qemu-kvm. Full details are available at:

Re: [PATCH 3/3] VMX: Enhance invalid guest state emulation

2009-08-31 Thread Avi Kivity
On 08/28/2009 05:49 PM, Mohammed Gamal wrote: - Change returned handle_invalid_guest_state() to return relevant exit codes - Move triggering the emulation from vmx_vcpu_run() to vmx_handle_exit() - Return to userspace instead of repeatedly trying to emulate instructions that have already failed

Re: RFC: shadow page table reclaim

2009-08-31 Thread Avi Kivity
On 08/31/2009 03:09 PM, Max Laier wrote: As you can see there is less saw- toothing in the after plot and also fewer changes overall (because we don't zap mappings that are still in use as often). This is with a limit of 64 for the shadow page table to increase the effect and vmx/ept. I

Re: [PATCH] don't call adjust_vmx_controls() second time

2009-08-31 Thread Andrew Theurer
Avi Kivity wrote: On 08/27/2009 11:42 PM, Andrew Theurer wrote: On Thu, 2009-08-27 at 19:21 +0300, Avi Kivity wrote: On 08/27/2009 06:41 PM, Gleb Natapov wrote: Don't call adjust_vmx_controls() two times for the same control. It restores options that was dropped earlier.

buildbot failure in qemu-kvm on default_x86_64_debian_5_0

2009-08-31 Thread qemu-kvm
The Buildbot has detected a new failure of default_x86_64_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/default_x86_64_debian_5_0/builds/38 Buildbot URL: http://buildbot.b1-systems.de/qemu-kvm/ Buildslave for this Build: b1_qemu_kvm_1

Re: buildbot failure in qemu-kvm on default_x86_64_debian_5_0

2009-08-31 Thread Daniel Gollub
On Monday 31 August 2009 03:17:04 pm qemu-...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure of default_x86_64_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/default_x86_64_debian_5_0/ builds/38 fatal: The

Re: buildbot failure in qemu-kvm on default_x86_64_debian_5_0

2009-08-31 Thread Avi Kivity
On 08/31/2009 04:24 PM, Daniel Gollub wrote: On Monday 31 August 2009 03:17:04 pm qemu-...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure of default_x86_64_debian_5_0 on qemu-kvm. Full details are available at:

KVM maintainership update

2009-08-31 Thread Avi Kivity
Starting now, Marcelo will co-maintain KVM with me. The plan is that we will commit on alternating weeks. There will be no change to any procedures -- patches should be posted to kvm@vger.kernel.org and will be applied to kvm.git and qemu-kvm.git on git.kernel.org. This move is intended to

Re: [PATCH 3/3] VMX: Enhance invalid guest state emulation

2009-08-31 Thread Avi Kivity
On 08/31/2009 04:39 PM, Mohammed Gamal wrote: local_irq_enable(); preempt_enable(); These are now wrong, since handle_invalid_exit() is called with interrupts and preemption enabled. Do you mean vmx_handle_exit() ? Yes. /* @@ -3405,9 +3412,12 @@ static

Re: [PATCH] don't call adjust_vmx_controls() second time

2009-08-31 Thread Avi Kivity
On 08/31/2009 04:05 PM, Andrew Theurer wrote: How does it compare to the other hypervisor now? My original results for other hypervisor were a little inaccurate. They mistakenly used 2 vcpu guests. New runs with 1 vcpu guests (as used in kvm) have slightly lower CPU utilization. Anyway,

Re: Extending virtio_console to support multiple ports

2009-08-31 Thread Amit Shah
On (Mon) Aug 31 2009 [08:17:21], Anthony Liguori wrote: - A lock has to be introduced to fetch one unused buffer from the list and pass it on to the host. And this lock has to be a spinlock, just because writes can be called from irq context. I don't see a problem here. You

Re: [PATCH] call vmx_load_host_state() only if msr is cached

2009-08-31 Thread Gleb Natapov
On Mon, Aug 31, 2009 at 11:04:27AM -0300, Marcelo Tosatti wrote: On Thu, Aug 27, 2009 at 03:07:30PM +0300, Gleb Natapov wrote: No need to call it before each kvm_(set|get)_msr_common() Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c

[PATCH] Remove unneeded printf() in kvm_run()

2009-08-31 Thread Avi Kivity
Snuck in during debugging. Signed-off-by: Avi Kivity a...@redhat.com --- qemu-kvm.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index d554749..7349c8d 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -965,7 +965,6 @@ int kvm_run(kvm_vcpu_context_t

Re: Extending virtio_console to support multiple ports

2009-08-31 Thread Anthony Liguori
Amit Shah wrote: Can you please explain your rationale for being so rigid about merging the two drivers? Because they do the same thing. I'm not going to constantly rehash this. It's been explained multiple times. If there are implementation issues within the Linux drivers because of

Re: Extending virtio_console to support multiple ports

2009-08-31 Thread Amit Shah
On (Mon) Aug 31 2009 [09:21:13], Anthony Liguori wrote: Amit Shah wrote: Can you please explain your rationale for being so rigid about merging the two drivers? Because they do the same thing. I'm not going to constantly rehash this. It's been explained multiple times. It hardly

Re: [PATCH] call vmx_load_host_state() only if msr is cached

2009-08-31 Thread Marcelo Tosatti
On Thu, Aug 27, 2009 at 03:07:30PM +0300, Gleb Natapov wrote: No need to call it before each kvm_(set|get)_msr_common() Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 6b57eed..7494ef1 100644 --- a/arch/x86/kvm/vmx.c +++

Re: [PATCHv5 3/3] vhost_net: a kernel-level virtio server

2009-08-31 Thread Arnd Bergmann
On Monday 31 August 2009, Xin, Xiaohui wrote: Hi, Michael That's a great job. We are now working on support VMDq on KVM, and since the VMDq hardware presents L2 sorting based on MAC addresses and VLAN tags, our target is to implement a zero copy solution using VMDq. I'm also interested

Re: Extending virtio_console to support multiple ports

2009-08-31 Thread Anthony Liguori
Amit Shah wrote: On (Mon) Aug 31 2009 [09:21:13], Anthony Liguori wrote: Amit Shah wrote: Can you please explain your rationale for being so rigid about merging the two drivers? Because they do the same thing. I'm not going to constantly rehash this. It's been explained

Re: Extending virtio_console to support multiple ports

2009-08-31 Thread Amit Shah
On (Mon) Aug 31 2009 [10:56:27], Anthony Liguori wrote: Amit Shah wrote: On (Mon) Aug 31 2009 [09:21:13], Anthony Liguori wrote: Amit Shah wrote: Can you please explain your rationale for being so rigid about merging the two drivers? Because they do the same thing. I'm

Re: Extending virtio_console to support multiple ports

2009-08-31 Thread Anthony Liguori
Amit Shah wrote: We're ending up having to compromise on the performance or functionality or simplicity the devices just because of this restriction. This is _not_ a high performance device and there so far has been no functionality impact. I don't understand why you keep dragging

Re: [PATCHv5 3/3] vhost_net: a kernel-level virtio server

2009-08-31 Thread Avi Kivity
On 08/31/2009 02:42 PM, Xin, Xiaohui wrote: Hi, Michael That's a great job. We are now working on support VMDq on KVM, and since the VMDq hardware presents L2 sorting based on MAC addresses and VLAN tags, our target is to implement a zero copy solution using VMDq. We stared from the

Re: vhost_net_init returned -7

2009-08-31 Thread Avi Kivity
On 08/30/2009 08:12 AM, Michael S. Tsirkin wrote: On Sat, Aug 29, 2009 at 04:38:25PM -0500, Brian Jackson wrote: I'm guessing that's not something the windows virtio drivers support yet. Do you plan on adding support for guests without msi or am I stuck waiting for the windows drivers to

Re: R/W HG memory mappings with kvm?

2009-08-31 Thread Stephen Donnelly
On Mon, Aug 31, 2009 at 8:44 PM, Avi Kivitya...@redhat.com wrote: On 08/31/2009 01:33 AM, Stephen Donnelly wrote: We can't duplicate mm/ in kvm.  However, mm/memory.c says:  * The way we recognize COWed pages within VM_PFNMAP mappings is through the  * rules set up by remap_pfn_range(): the

Re: [PATCHv5 3/3] vhost_net: a kernel-level virtio server

2009-08-31 Thread Anthony Liguori
Avi Kivity wrote: On 08/31/2009 02:42 PM, Xin, Xiaohui wrote: Hi, Michael That's a great job. We are now working on support VMDq on KVM, and since the VMDq hardware presents L2 sorting based on MAC addresses and VLAN tags, our target is to implement a zero copy solution using VMDq. We stared

Re: [TOOL] c2kpe: C expression to kprobe event format converter

2009-08-31 Thread Frederic Weisbecker
On Mon, Aug 31, 2009 at 12:14:34AM -0400, Masami Hiramatsu wrote: Frederic Weisbecker wrote: On Thu, Aug 13, 2009 at 04:59:19PM -0400, Masami Hiramatsu wrote: This program converts probe point in C expression to kprobe event format for kprobe-based event tracer. This helps to define kprobes

[[PATCH v2]] VMX: Enhance invalid guest state emulation

2009-08-31 Thread Mohammed Gamal
- Change returned handle_invalid_guest_state() to return relevant exit codes - Move triggering the emulation from vmx_vcpu_run() to vmx_handle_exit() - Return to userspace instead of repeatedly trying to emulate instructions that have already failed Signed-off-by: Mohammed Gamal

[PATCH v2] VMX: Enhance invalid guest state emulation

2009-08-31 Thread Mohammed Gamal
- Change returned handle_invalid_guest_state() to return relevant exit codes - Move triggering the emulation from vmx_vcpu_run() to vmx_handle_exit() - Return to userspace instead of repeatedly trying to emulate instructions that have already failed Signed-off-by: Mohammed Gamal

[PATCH 1/2][RESEND] Update kvm.h in qemu-kvm tree

2009-08-31 Thread Mohammed Gamal
Update struct kvm_run and KVM_EXIT_* constants to match the one in the kernel-space tree Signed-off-by: Mohammed Gamal m.gamal...@gmail.com --- kvm/include/linux/kvm.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/kvm/include/linux/kvm.h b/kvm/include/linux/kvm.h

[PATCH 2/2][RESEND] Handle emulation failure in userspace

2009-08-31 Thread Mohammed Gamal
Since we return to userspace from KVM on invalid state emulation failure, let qemu handle it. Signed-off-by: Mohammed Gamal m.gamal...@gmail.com --- qemu-kvm.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index b59e403..a1648e0 100644

[PATCH][RESEND] x86 emulator: Add pusha and popa instructions

2009-08-31 Thread Mohammed Gamal
This adds pusha and popa instructions (opcodes 0x60-0x61), this enables booting MINIX with invalid guest state emulation on. Signed-off-by: Mohammed Gamal m.gamal...@gmail.com --- arch/x86/kvm/emulate.c | 52 +++- 1 files changed, 51 insertions(+), 1

RE: [PATCHv5 3/3] vhost_net: a kernel-level virtio server

2009-08-31 Thread Xin, Xiaohui
One way to share the effort is to make vmdq queues available as normal kernel interfaces. It would take quite a bit of work, but the end result is that no other components need to be change, and it makes vmdq useful outside kvm. It also greatly reduces the amount of integration work needed

[COMMIT master] Merge branch 'upstream-merge'

2009-08-31 Thread Avi Kivity
From: Avi Kivity a...@redhat.com * upstream-merge: (142 commits) Fix gcc 3 warning: comparison is always true due to limited range of data type Fix gcc 3 warning about uninitialized variable Sparc32: port Slavio misc devices to VMState design Sparc32: port ECC memory controller to VMState

[COMMIT master] Fix mpstate reloads

2009-08-31 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/hw/apic.c b/hw/apic.c index 18db3be..68e5de3 100644 --- a/hw/apic.c +++ b/hw/apic.c @@ -488,6 +488,7 @@ void apic_init_reset(CPUState *env) if (!s) return; +cpu_synchronize_state(env);

[COMMIT master] Revert back to rtl8139 as default nic

2009-08-31 Thread Avi Kivity
From: Avi Kivity a...@redhat.com e1000 is not supported well on Windows XP. Signed-off-by: Avi Kivity a...@redhat.com diff --git a/hw/pc.c b/hw/pc.c index 571c195..a84b2d3 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -1276,7 +1276,7 @@ static void pc_init1(ram_addr_t ram_size, continue;

[COMMIT master] KVM: x86 emulator: Add missing decoder flags for 'or' instructions

2009-08-31 Thread Avi Kivity
From: Mohammed Gamal m.gamal...@gmail.com Add missing decoder flags for or instructions (0xc-0xd). Signed-off-by: Mohammed Gamal m.gamal...@gmail.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 0644d3d..db0820d 100644 ---

[COMMIT master] KVM guest: fix bogus wallclock physical address calculation

2009-08-31 Thread Avi Kivity
From: Glauber Costa glom...@redhat.com The use of __pa() to calculate the address of a C-visible symbol is wrong, and can lead to unpredictable results. See arch/x86/include/asm/page.h for details. It should be replaced with __pa_symbol(), that does the correct math here, by taking relocations